https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Bug ID: 1250526 Summary: Review Request: perl-Iterator-Simple-Lookahead - Simple iterator with look-ahead and unget Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ppisar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ppisar.fedorapeople.org/perl-Iterator-Simple-Lookahead/perl-Iterator... SRPM URL: https://ppisar.fedorapeople.org/perl-Iterator-Simple-Lookahead/perl-Iterator... Description: This Perl module encapsulates an iterator that allows the user to peek the Nth element without consuming it or to push elements back to the iterated stream.
Fedora Account System Username: ppisar
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1250447
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1250447 [Bug 1250447] Review Request: perl-Iterator-Simple - Simple iterator and utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
--- Comment #1 from Petr Šabata psabata@redhat.com --- * Missing buildtime dependency: sed, used on line 46
* Correct EOLs of lib/Iterator/Simple/Lookahead.pm, too.
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
--- Comment #2 from Petr Pisar ppisar@redhat.com --- (In reply to Petr Šabata from comment #1)
- Missing buildtime dependency: sed, used on line 46
I fixed it. Updated package is on the same URL.
- Correct EOLs of lib/Iterator/Simple/Lookahead.pm, too.
I do not want to convert this file. It's a code, not a documentation. In my opinion, EOL normalization applies to documentation only.
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Šabata psabata@redhat.com --- (In reply to Petr Pisar from comment #2)
(In reply to Petr Šabata from comment #1)
- Missing buildtime dependency: sed, used on line 46
I fixed it. Updated package is on the same URL.
Ack.
- Correct EOLs of lib/Iterator/Simple/Lookahead.pm, too.
I do not want to convert this file. It's a code, not a documentation. In my opinion, EOL normalization applies to documentation only.
It's kind of both. The file even contains more POD than Perl code :) Anyhow, subjective and non-critical. Approving.
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Petr Pisar ppisar@redhat.com --- New Package SCM Request ======================= Package Name: perl-Iterator-Simple-Lookahead Short Description: Simple iterator with look-ahead and unget Upstream URL: http://search.cpan.org/dist/Iterator-Simple-Lookahead/ Owners: ppisar jplesnik psabata Branches: InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1250526 Bug 1250526 depends on bug 1250447, which changed state.
Bug 1250447 Summary: Review Request: perl-Iterator-Simple - Simple iterator and utilities https://bugzilla.redhat.com/show_bug.cgi?id=1250447
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Iterator-Simple-Lookah | |ead-0.07-1.fc24 Resolution|--- |RAWHIDE Last Closed| |2015-08-25 09:59:20
--- Comment #6 from Petr Pisar ppisar@redhat.com --- Thank you for the review and the repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #7 from Petr Pisar ppisar@redhat.com --- Package Change Request ====================== Package Name: perl-Iterator-Simple-Lookahead New Branches: f23 Owners: ppisar jplesnik psabata InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1259340
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Iterator-Simple-0.06-1.fc23 perl-Iterator-Simple-Lookahead-0.07-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14985
https://bugzilla.redhat.com/show_bug.cgi?id=1250526 Bug 1250526 depends on bug 1250447, which changed state.
Bug 1250447 Summary: Review Request: perl-Iterator-Simple - Simple iterator and utilities https://bugzilla.redhat.com/show_bug.cgi?id=1250447
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |---
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords| |Reopened
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Iterator-Simple-0.06-1.fc23, perl-Iterator-Simple-Lookahead-0.07-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-Iterator-Simple-Lookahead perl-Iterator-Simple'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14985
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Iterator-Simple-0.06-1.fc23, perl-Iterator-Simple-Lookahead-0.07-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1250526 Bug 1250526 depends on bug 1250447, which changed state.
Bug 1250447 Summary: Review Request: perl-Iterator-Simple - Simple iterator and utilities https://bugzilla.redhat.com/show_bug.cgi?id=1250447
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1250526
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version|perl-Iterator-Simple-Lookah |0.06-1.fc23 |ead-0.07-1.fc24 | Resolution|--- |NEXTRELEASE Last Closed|2015-08-25 09:59:20 |2015-09-21 06:51:04
package-review@lists.fedoraproject.org