Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575466
--- Comment #18 from Germán Racca <gracca(a)gmail.com> 2010-11-05 16:33:39 EDT ---
(In reply to comment #17)
Hi Hans:
Thanks for the review!
Full review done, results below:
Good:
- rpmlint checks return:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, text in %doc
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Needs work:
-%install
Is missing a
rm -rf %{buildroot}
As the first line, this is not strictly needed anymore, but if you're going
to not do it also remove %clean and the setting of BuildRoot
I decided to clean the buildroot in %install.
-You're not preserving timestamps when installing the files from
Aurora.tar.bz2 (replace "cp -r" with "cp -pr")
Fixed.
-Needs a "Requires: gtk2", because 1: it is useless without
gtk2,
2: for %{_libdir}/gtk-2.0/2.10.0/engines dir ownership
You're completely right. Also I'm going to add that requires to other gtk
engine I maintain :)
-You should mail upstream about adding copyright headers to there
files if not
done already (not a blocker)
I've mailed the author of the engine last year and this year several times, but
no answer at all :(
Please find updated files here:
SPEC:
http://skytux.fedorapeople.org/packages/gtk-aurora-engine.spec
SRPM:
http://skytux.fedorapeople.org/packages/gtk-aurora-engine-1.5.1-4.fc13.sr...
rpmlint output:
Checking RPM package (gtk-aurora-engine-1.5.1-4.fc13.i686.rpm)
--------------------
gtk-aurora-engine.i686: W: unstripped-binary-or-object
/usr/lib/gtk-2.0/2.10.0/engines/libaurora.so
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Checking SPEC file (gtk-aurora-engine.spec)
------------------
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Checking SRPM package (gtk-aurora-engine-1.5.1-4.fc13.src.rpm)
---------------------
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.