Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: php-horde-Horde-Stream-Wrapper - Horde Stream wrappers
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Summary: Review Request: php-horde-Horde-Stream-Wrapper - Horde Stream wrappers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nb@fedoraproject.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.... Description: This package provides various stream wrappers.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |785424
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |785455(horde-support)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |horde-stream-wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=785471
--- Comment #1 from Nick Bebout nb@fedoraproject.org --- Updated
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0....
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Created attachment 595422 --> https://bugzilla.redhat.com/attachment.cgi?id=595422&action=edit php-horde-Horde-Stream-Wrapper-review.txt
Generated by fedora-review 0.1.3
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #3 from Remi Collet fedora@famillecollet.com --- SHOULD: Use %{pear_name} where possible Consider adding %{pear_channel}
MUST: [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install.
[!]: MUST Requires correct, justified where necessary. BuildRequires and Requires same version of pear, according to package.xml BuildRequires: php-pear >= 1:1.7.0 Requires: php-pear >= 1:1.7.0
Also add php-common >= 5.2.0 (waiting for a better provides in php)
[!]: MUST Package must own all directories that it creates. Missing %{pear_phpdir}/Horde %{pear_phpdir}/Horde/Stream %{pear_docdir}/Horde_Stream_Wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=785471
--- Comment #4 from Nick Bebout nb@fedoraproject.org --- Updated
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0....
https://bugzilla.redhat.com/show_bug.cgi?id=785471
--- Comment #5 from Remi Collet fedora@famillecollet.com --- [!]: MUST Package must own all directories that it creates. Missing %{pear_phpdir}/Horde
And you should, of course remove (included in previous) %{pear_phpdir}/Horde/Stream %{pear_phpdir}/Horde/Stream/Wrapper
Please use macro everywhere, see %postun and %files
It's probably enough to only %doc %{pear_docdir}/%{pear_name}
Note : "localized" php.ini is use less in fedora (date.timezone defined in pear wrapper), I haven't check in EL.
https://bugzilla.redhat.com/show_bug.cgi?id=785471
--- Comment #6 from Nick Bebout nb@fedoraproject.org --- Updated
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0....
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Remi Collet fedora@famillecollet.com --- Blockers fixed.
== APPROVED ==
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from Nick Bebout nb@fedoraproject.org --- New Package SCM Request ======================= Package Name: php-horde-Horde-Stream-Wrapper Short Description: This package provides various stream wrappers for Horde Owners: nb Branches: el6 f16 f17 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=785471
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=785471
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2012-07-18 18:05:22
package-review@lists.fedoraproject.org