https://bugzilla.redhat.com/show_bug.cgi?id=1329807
Bug ID: 1329807 Summary: Review Request: raqm - Complex Textlayout Library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: moceap@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://pastebin.com/raw/hWvn0dk7 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-24-x86_64... Description: Complex Textlayout Library Fedora Account System Username: moceap
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
Mosaab Alzoubi moceap@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1329817
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1329817 [Bug 1329817] Enable complex textlayout on ImageMagick
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- raqm.src: E: description-line-too-long C Library that encapsulates the logic for complex text layout and provide a convenient API.
Also "provides" not "provide".
raqm-devel.x86_64: W: no-dependency-on raqm/raqm-libs/libraqm
raqm-devel.x86_64: E: non-devel-file-in-devel-package /usr/lib64/libraqm.so.0.0.0 raqm-devel.x86_64: E: library-without-ldconfig-postin /usr/lib64/libraqm.so.0.0.0 raqm-devel.x86_64: E: library-without-ldconfig-postun /usr/lib64/libraqm.so.0.0.0 → .so should be in -devel, .so.* in the main package.
%license should be used for the license file.
No %check? Upstream README says that there are unit tests.
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #2 from Mosaab Alzoubi moceap@hotmail.com --- Spec URL: http://pastebin.com/raw/q8Ycfukd SRPM URL: https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-23-x86_64...
Everything's OK
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- -devel must require specific version: raqm%{?_isa} = %{version}-%{release}
Wouldn't it be better to call this package libraqm? Upstream uses both "libraqm" and "raqm" in various places. That's the package name in arch linux, and consistency with other distributions is useful for users. Also it's a library, so "lib" prefix is helpful.
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #4 from Mosaab Alzoubi moceap@hotmail.com --- Spec URL: http://pastebin.com/raw/AXqVRH7a SRPM URL: https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-rawhide-x...
Yes libraqm's better, no applications in main package (pure lib)
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
Mosaab Alzoubi moceap@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: raqm - |Review Request: libraqm - |Complex Textlayout Library |Complex Textlayout Library
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- + license is OK + package name is OK + license file is present, %license is used + scriptlets look sane + provides/requires look sane (one exception below)
Package is APPROVED.
- main package should not have a dependency (Requires) on -devel.
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #6 from Mosaab Alzoubi moceap@hotmail.com --- VERY THANK YOU FOR FAST RESPONDING :)
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libraqm
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-31501b1f76
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f49283081a
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-de4bc206ba
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7987fa6183
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f49283081a
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-de4bc206ba
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-31501b1f76
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7987fa6183
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-05-02 14:53:10
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1329807
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- libraqm-0.1.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org