https://bugzilla.redhat.com/show_bug.cgi?id=1487420
--- Comment #6 from Raphael Groner <projects.rg(a)smart.ms> ---
First of all, some general advices:
- Drop Group tag, it's obsolete.
- Replace all occurences of 'Django' with %{pkgname}, why else define a macro?
- Why no support for python3?
https://fedoraproject.org/wiki/Packaging:Python
- There seems to be a conflict with the virtual provides compared to
python-django package. Would an update remove python-django16 in case there's
a newer version of python-django itself? Please try to avoid any conflict.
https://fedoraproject.org/wiki/Packaging:Conflicts
- Can the tests get fixed? Did upstream get poked when version 1.6 was latest?
- Use '%license COPYING'.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#macros
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE-JQUERY.txt is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: python-django.spec should be python-django16.spec
See:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[?]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
=> Can not validate, see above.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
[!]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[?]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[?]: Python eggs must not download any dependencies during the build
process.
=> Can not validate, see above.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
===== SHOULD items =====
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[-]: Latest version is packaged.
=> This is a compatibility package.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
=> Task info:
https://koji.fedoraproject.org/koji/taskinfo?taskID=22047262
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Bad spec filename: /home/builder/fedora-review/1487420-python-
django/srpm-unpacked/python-django.spec
See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: python-django16-1.6.11.6-2.fc28.noarch.rpm
python-django16-1.6.11.6-2.fc28.src.rpm
python-django16.noarch: W: incoherent-version-in-changelog 1.6.11.6-1
['1.6.11.6-2.fc28', '1.6.11.6-2']
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/daily_cleanup.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/django-2to3.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/django-admin.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/profiling/gather_profile_stats.py
/usr/bin/env python
python-django16.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/profiling/gather_profile_stats.py
644 /usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/unique-messages.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/conf/project_template/manage.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/contrib/admin/bin/compress.py
/usr/bin/env python
python-django16.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/contrib/admin/bin/compress.py
644 /usr/bin/env python
python-django16.src: W: spelling-error %description -l en_US Django -> Fandango
python-django16.src: E: invalid-spec-name
2 packages and 0 specfiles checked; 10 errors, 2 warnings.
Rpmlint (installed packages)
----------------------------
python-django16.noarch: W: spelling-error Summary(en_US) high -> highly
python-django16.noarch: W: spelling-error Summary(en_US) level -> eviller
python-django16.noarch: W: spelling-error Summary(en_US) framework -> mainframe
python-django16.noarch: W: spelling-error %description -l en_US a -> h, N, T
python-django16.noarch: W: spelling-error %description -l en_US high -> highly
python-django16.noarch: W: spelling-error %description -l en_US level ->
eviller
python-django16.noarch: W: spelling-error %description -l en_US framework ->
mainframe
python-django16.noarch: W: spelling-error %description -l en_US that -> hat,
path
python-django16.noarch: W: spelling-error %description -l en_US encourages
python-django16.noarch: W: spelling-error %description -l en_US rapid -> raped
python-django16.noarch: W: spelling-error %description -l en_US development
python-django16.noarch: W: spelling-error %description -l en_US and -> handle
python-django16.noarch: W: spelling-error %description -l en_US pragmatic
python-django16.noarch: W: spelling-error %description -l en_US design ->
demigod
python-django16.noarch: W: spelling-error %description -l en_US It -> Bit, Kit,
Ii
python-django16.noarch: W: spelling-error %description -l en_US focuses ->
confusers
python-django16.noarch: W: spelling-error %description -l en_US on -> con, won,
op
python-django16.noarch: W: spelling-error %description -l en_US automating ->
inflating
python-django16.noarch: W: spelling-error %description -l en_US as -> gas, Cs,
Ks
python-django16.noarch: W: spelling-error %description -l en_US much -> munch
python-django16.noarch: W: spelling-error %description -l en_US possible ->
fossil
python-django16.noarch: W: spelling-error %description -l en_US adhering ->
hammering
python-django16.noarch: W: spelling-error %description -l en_US to -> toy
python-django16.noarch: W: spelling-error %description -l en_US the -> tee,
theory
python-django16.noarch: W: spelling-error %description -l en_US principle ->
crippleware
python-django16.noarch: W: spelling-error %description -l en_US This -> Thuds
python-django16.noarch: W: spelling-error %description -l en_US version ->
recursion
python-django16.noarch: W: spelling-error %description -l en_US exists ->
chemists
python-django16.noarch: W: spelling-error %description -l en_US solely ->
console
python-django16.noarch: W: spelling-error %description -l en_US recommended
python-django16.noarch: W: spelling-error %description -l en_US not -> bot,
notwork
python-django16.noarch: W: spelling-error %description -l en_US use -> user
python-django16.noarch: W: spelling-error %description -l en_US for -> fora,
foo
python-django16.noarch: W: spelling-error %description -l en_US other -> theory
python-django16.noarch: W: spelling-error %description -l en_US purposes ->
posers
python-django16.noarch: W: incoherent-version-in-changelog 1.6.11.6-1
['1.6.11.6-2.fc28', '1.6.11.6-2']
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/daily_cleanup.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/django-2to3.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/django-admin.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/profiling/gather_profile_stats.py
/usr/bin/env python
python-django16.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/profiling/gather_profile_stats.py
644 /usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/bin/unique-messages.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/conf/project_template/manage.py
/usr/bin/env python
python-django16.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/contrib/admin/bin/compress.py
/usr/bin/env python
python-django16.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/Django-1.6.11.6-py2.7.egg/django/contrib/admin/bin/compress.py
644 /usr/bin/env python
1 packages and 0 specfiles checked; 9 errors, 36 warnings.
Requires
--------
python-django16 (rpmlib, GLIBC filtered):
/usr/bin/env
/usr/bin/python2
python(abi)
Provides
--------
python-django16:
Django
django
python-django16
python2.7dist(django)
python2dist(django)
Source checksums
----------------
https://downloads.reviewboard.org/releases/Django/1.6/Django-1.6.11.6.tar.gz :
CHECKSUM(SHA256) this package :
d46de3e9e7f8a8567cae95e5a23b678630e734b29b993160119e9ec5e308dc9d
CHECKSUM(SHA256) upstream package :
d46de3e9e7f8a8567cae95e5a23b678630e734b29b993160119e9ec5e308dc9d
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1487420
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component