https://bugzilla.redhat.com/show_bug.cgi?id=827761
Bug ID: 827761 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: 17 Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: vdr-skinenigmang - A skin for VDR based on the Enigma text2skin add on Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mgansser@alice.de Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
skinenigmang a skin for VDR based on the Enigma text2skin add on.
SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skine...
Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skine...
rpmlint output: rpmlint vdr-skinenigmang-0.1.2-2.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint vdr-skinenigmang-0.1.2-2.fc17.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint vdr-skinenigmang-debuginfo-0.1.2-2.fc17.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #1 from MartinKG mgansser@alice.de --- SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skine...
Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skine...
changelog: * Tue Jun 12 2012 Martin Gansser linux4martin@gmx.de - 0.1.2-3 - added config patch - added flag and icons in file section - spec file cleanup
https://bugzilla.redhat.com/show_bug.cgi?id=827761
Ville Skyttä ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ville.skytta@iki.fi Flags| |fedora-review?
--- Comment #2 from Ville Skyttä ville.skytta@iki.fi ---
install -pm 644 %{SOURCE1} skinenigmang/flags
This copies the skinenigmang-logos-xpm-hi-20070702.tgz tarball to skinenigmang/flags, and it ends up in the binary package. Why is that?
Other than that, looks pretty good to me on a quick look.
https://bugzilla.redhat.com/show_bug.cgi?id=827761
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m
--- Comment #3 from Mario Blättermann mario.blaettermann@gmail.com --- (In reply to comment #2)
install -pm 644 %{SOURCE1} skinenigmang/flags
This copies the skinenigmang-logos-xpm-hi-20070702.tgz tarball to skinenigmang/flags, and it ends up in the binary package. Why is that?
It's unusual to call install in the %prep section. The Source1 should be unpacked only. This way, the binary package contains the xpm files only, not the tarball itself.
https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #4 from MartinKG mgansser@alice.de --- thanks Mario, fixed in new rpm package.
Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/0.1.2-4/v...
SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/0.1.2-4/v...
%changelog * Thu Jun 14 2012 Martin Gansser linux4martin@gmx.de - 0.1.2-4 - more spec file cleanups - fixed copying of source file to build dir
https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #5 from Ville Skyttä ville.skytta@iki.fi --- URL is wrong, should probably be http://andreas.vdr-developer.org/enigmang/
License should probably be GPL+, I couldn't find anything in the tarball that'd say GPLv2+ (I've sent a patch for this upstream, so future versions may be GPLv2+).
https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #6 from MartinKG mgansser@alice.de --- SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skine...
Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skine...
%changelog * Sun Jun 16 2012 Martin Gansser linux4martin@gmx.de - 0.1.2-5 - fixed wrong url - changed license type from GPLv2+ to GPL+
https://bugzilla.redhat.com/show_bug.cgi?id=827761
Ville Skyttä ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Ville Skyttä ville.skytta@iki.fi --- The only thing I'm slightly wondering about is whether the theme files should have %{vdr_user}:root ownership instead of root:root - that's how other skins package them.
Anyway, I'll leave that up to you to decide before the first build, approved.
https://bugzilla.redhat.com/show_bug.cgi?id=827761
MartinKG mgansser@alice.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|ville.skytta@iki.fi |nobody@fedoraproject.org Flags|fedora-review+ |fedora-review?
--- Comment #8 from MartinKG mgansser@alice.de --- New Package SCM Request ======================= Package Name: vdr-skinenigmang Short Description: a skin for VDR based on the Enigma text2skin add on. Owners: martinkg Branches: f16 f17 f18 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=827761
MartinKG mgansser@alice.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=827761
Ville Skyttä ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ville.skytta@iki.fi Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=827761
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|vdr-skinenigmang - A skin |Review Request: |for VDR based on the Enigma |vdr-skinenigmang - A skin |text2skin add on |for VDR based on the Enigma | |text2skin add on
https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Don't request f18 yet, it's still devel.
https://bugzilla.redhat.com/show_bug.cgi?id=827761
MartinKG mgansser@alice.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Flags|fedora-review+ |fedora-review? Last Closed| |2012-06-19 12:58:41
--- Comment #10 from MartinKG mgansser@alice.de --- the package built successfully on koji
https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- vdr-skinenigmang-0.1.2-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/vdr-skinenigmang-0.1.2-5.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- vdr-skinenigmang-0.1.2-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/vdr-skinenigmang-0.1.2-5.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=827761
Ville Skyttä ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=827761
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NEXTRELEASE |ERRATA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- vdr-skinenigmang-0.1.2-5.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- vdr-skinenigmang-0.1.2-5.fc16 has been pushed to the Fedora 16 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- vdr-skinenigmang-0.1.2-11.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/vdr-skinenigmang-0.1.2-11.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=827761
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|ERRATA |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=827761
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- vdr-skinenigmang-0.1.2-11.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org