https://bugzilla.redhat.com/show_bug.cgi?id=1230227
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |ppisar(a)redhat.com
Assignee|nobody(a)fedoraproject.org |ppisar(a)redhat.com
Flags| |fedora-review?
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
URL and Source0 address are usable. Ok.
Source archive is original (SHA-256:
d7b397e2fc07cfb00c1d9a76ee790f07462a3b2cbeb5fc951dfeb134b0ada867). Ok.
Summary verified from lib/HTTP/Headers/Fast.pm. Ok.
Description verified from lib/HTTP/Headers/Fast.pm. OK.
License verified from lib/HTTP/Headers/Fast.pm and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.
TODO: You can remove the command for deleting empty directories in the %install
section.
FIX: Build-require `perl(CPAN::Meta)' (Build.PL:15).
FIX: Build-require `perl(CPAN::Meta::Prereqs)' (Build.PL:16).
FIX: Build-require `perl(File::Basename)' (Build.PL:13).
FIX: Build-require `perl(strict)' (Build.PL:8).
FIX: Build-require `perl(utf8)' (Build.PL:10).
FIX: Build-require `perl(warnings)' (Build.PL:9).
FIX: Build-require `perl(MIME::Base64)' (lib/HTTP/Headers/Fast.pm:466).
FIX: Build-require `perl(Storable)' (lib/HTTP/Headers/Fast.pm:357).
FIX: Build-require `perl(Test)' (t/headers.t:4).
All tests pass. Ok.
$ rpmlint perl-HTTP-Headers-Fast.spec
../SRPMS/perl-HTTP-Headers-Fast-0.17-1.fc24.src.rpm
../RPMS/noarch/perl-HTTP-Headers-Fast-0.17-1.fc24.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-Headers-Fast-0.17-1.fc24.noarch.rpm
drwxr-xr-x 2 root root 0 Aug 6 17:04
/usr/share/doc/perl-HTTP-Headers-Fast
-rw-r--r-- 1 root root 1565 Nov 14 2013
/usr/share/doc/perl-HTTP-Headers-Fast/Changes
-rw-r--r-- 1 root root 2106 Nov 14 2013
/usr/share/doc/perl-HTTP-Headers-Fast/README.md
drwxr-xr-x 2 root root 0 Aug 6 17:04
/usr/share/licenses/perl-HTTP-Headers-Fast
-rw-r--r-- 1 root root 18449 Nov 14 2013
/usr/share/licenses/perl-HTTP-Headers-Fast/LICENSE
-rw-r--r-- 1 root root 2704 Aug 6 17:04
/usr/share/man/man3/HTTP::Headers::Fast.3pm.gz
drwxr-xr-x 2 root root 0 Aug 6 17:04
/usr/share/perl5/vendor_perl/HTTP
drwxr-xr-x 2 root root 0 Aug 6 17:04
/usr/share/perl5/vendor_perl/HTTP/Headers
-rw-r--r-- 1 root root 15132 Aug 6 17:04
/usr/share/perl5/vendor_perl/HTTP/Headers/Fast.pm
File permissions and layout are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-HTTP-Headers-Fast-0.17-1.fc24.noarch.rpm | sort -f | uniq
-c
1 perl >= 0:5.00800
1 perl(:MODULE_COMPAT_5.22.0)
1 perl(Carp)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require `perl(HTTP::Date)' (lib/HTTP/Headers/Fast.pm:365).
FIX: Run-require `perl(MIME::Base64)' (lib/HTTP/Headers/Fast.pm:466).
FIX: Run-require `perl(Storable)' (lib/HTTP/Headers/Fast.pm:357).
$ rpm -q --provides -p
../RPMS/noarch/perl-HTTP-Headers-Fast-0.17-1.fc24.noarch.rpm | sort -f | uniq
-c
1 perl(HTTP::Headers::Fast) = 0.17
1 perl-HTTP-Headers-Fast = 0.17-1.fc24
Binary provides are Ok.
Package builds in F24
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=10623584). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all `FIX' items, consider fixing `TODO' items, and provide new
spec file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component