https://bugzilla.redhat.com/show_bug.cgi?id=1037900
Bug ID: 1037900 Summary: Review Request: rubygem-resque-job-stats - Job-centric stats for Resque Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ktdreyer@ktdreyer.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats-0.3.0-1.fc... Description: Tracks jobs performed, failed, and the duration of the last 100 jobs for each job type. Fedora Account System Username: ktdreyer
F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6254316
https://bugzilla.redhat.com/show_bug.cgi?id=1037900
--- Comment #1 from Ken Dreyer ktdreyer@ktdreyer.com --- Here's an updated version that follows the latest Ruby guidelines for F21.
Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-resque-job-stats.gi...
Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats-0.3.0-2.fc...
F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6898274
https://bugzilla.redhat.com/show_bug.cgi?id=1037900
--- Comment #2 from Ken Dreyer ktdreyer@ktdreyer.com --- Here's an updated version that works with the newest Redis package in Fedora.
Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-resque-job-stats.gi...
Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats-0.3.0-3.fc...
F22 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7133514
https://bugzilla.redhat.com/show_bug.cgi?id=1037900
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |valtri@civ.zcu.cz
--- Comment #3 from František Dvořák valtri@civ.zcu.cz --- Trying a review... (although unexperienced, I don't have any ruby package yet)
Found only cosmetics (nothing needs to be changed):
1) For downloading sources you can consider client that preserves the upstream timestamps:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#T...
2) Why is the '%exclude %{gem_instdir}/test' in -doc subpackage? But there is probably no reason why not.
Remarks:
* You're patching out development files in %prep. It is true it may be better than using %exclude in %files, right? (Files won't be installed, they won't be there during testing...).
* %check section: It looks like redis-server listens only on IPv4 and communication during testing goes through 127.0.0.1. But it works well in koji and even on IPv6-only machine.
Would you agree for review swap with rubygem-json_spec (#1079640)? But I can do formal review here anyway. :-)
Thank you, František
https://bugzilla.redhat.com/show_bug.cgi?id=1037900
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1037900
--- Comment #4 from František Dvořák valtri@civ.zcu.cz --- I know the formal process of review has not started, but I guess this review can be considered as stalled and closed.
But I can review, if you're interested in it. Over time there are some new issues to consider, for example:
* %license tag has been added into guidelines * Fedora 20 conditional macros can be removed * upstream searches for new maintainer
https://bugzilla.redhat.com/show_bug.cgi?id=1037900
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed| |2016-11-16 17:13:55
package-review@lists.fedoraproject.org