https://bugzilla.redhat.com/show_bug.cgi?id=823333
Bug ID: 823333 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: rubygem-mixlib-cli Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: rpms@courteau.org Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: https://raw.github.com/jcourteau/rubygems-rpms/master/fc17/rubygem-mixlib-cl... SRPM URL: http://rpms.courteau.org/fedora/rubygem-mixlib-cli-1.2.2-1.fc17.src.rpm
Description: A simple (Rubygem) mixin for CLI interfaces, including option parsing.
This is part of a set of dependencies for rubygem-chef. I've got about 14 packages to add, all ruby gems, and am looking for a sponsor. Several of the packages were previously in Fedora (F11 and F12), but were removed due to lack of a maintainer.
https://bugzilla.redhat.com/show_bug.cgi?id=823333
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |823352
https://bugzilla.redhat.com/show_bug.cgi?id=823333
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841
https://bugzilla.redhat.com/show_bug.cgi?id=823333
Jonas Courteau rpms@courteau.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rubygem-mixlib-cli |rubygem-mixlib-cli - a ruby | |gem mixin for CLI support, | |including option parsing
https://bugzilla.redhat.com/show_bug.cgi?id=823333
Jonas Courteau rpms@courteau.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 |823344
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jdunn@aquezada.com, | |jstribny@redhat.com
--- Comment #1 from Josef Stribny jstribny@redhat.com --- * Remove Requires: ruby for other Ruby interpretations to be used with in f19
* Rakefile, NOTICE and README.rdoc are not require during runtime - Please consider moving them into the -doc subpackage
* Please consider moving specs into the -doc subpackage rather than exclude them
* I would suggest you to exclude %{gem_cache} as it's not needed
* Tests print:
........You must supply -r! Usage: /usr/local/bin/rspec (options) -r ......
- Tests shouldn't print STDOUT like this. It could be fixed by something suggested on stackoverflow [1].
[1] http://stackoverflow.com/questions/1496019/suppresing-output-to-console-with...
@Julian C. Dunn: Adding you to CC. Could you please take over this bug?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #2 from Julian C. Dunn jdunn@aquezada.com --- (In reply to comment #1)
Remove Requires: ruby for other Ruby interpretations to be used with in f19
Rakefile, NOTICE and README.rdoc are not require during runtime
- Please consider moving them into the -doc subpackage
Please consider moving specs into the -doc subpackage rather than exclude
them
- I would suggest you to exclude %{gem_cache} as it's not needed
All of the above have been corrected.
- Tests print:
........You must supply -r! Usage: /usr/local/bin/rspec (options) -r ......
- Tests shouldn't print STDOUT like this. It could be fixed by something
suggested on stackoverflow [1].
I added a patch for this to the SRPM, though I don't know if it'll be accepted upstream -- it's a matter of taste and the fix is kind of dirty. But it will silence output to STDOUT on the tests.
Please have a look:
http://jdunn.fedorapeople.org/rubygem-mixlib-cli/rubygem-mixlib-cli.spec http://jdunn.fedorapeople.org/rubygem-mixlib-cli/rubygem-mixlib-cli-1.2.2-2....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |jstribny@redhat.com QA Contact|extras-qa@fedoraproject.org |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Josef Stribny jstribny@redhat.com --- * %{gem_instdir}/NOTICE and %{gem_instdir}/README.rdoc should be marked as %doc
Otherwise the package is fine. Rpmlint gave me no errors and it builds in Koji -> APPROVED. Please mark the above mentioned files as %doc before pushing. Thanks.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #4 from Vít Ondruch vondruch@redhat.com --- (In reply to comment #2)
I added a patch for this to the SRPM, though I don't know if it'll be accepted upstream -- it's a matter of taste and the fix is kind of dirty. But it will silence output to STDOUT on the tests.
Julien, could you please always try to comment what is the patch about? Its purpose, its source etc. It is good to know if you submit the patch upstream, what is the status or if you taken the patch from upstream, when it can be dropped etc.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #5 from Julian C. Dunn jdunn@aquezada.com --- (In reply to comment #4)
(In reply to comment #2)
I added a patch for this to the SRPM, though I don't know if it'll be accepted upstream -- it's a matter of taste and the fix is kind of dirty. But it will silence output to STDOUT on the tests.
Julien, could you please always try to comment what is the patch about? Its purpose, its source etc. It is good to know if you submit the patch upstream, what is the status or if you taken the patch from upstream, when it can be dropped etc.
Sure, no problem. Thanks for the advice.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
Julian C. Dunn jdunn@aquezada.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Julian C. Dunn jdunn@aquezada.com --- Package Change Request ====================== Package Name: rubygem-mixlib-cli New Branches: f16 f17 f18 Owners: jdunn InitialCC:
Unretire package.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-cli-1.2.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-mixlib-cli-1.2.2-3.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-cli-1.2.2-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-mixlib-cli-1.2.2-3.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-cli-1.2.2-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-mixlib-cli-1.2.2-3.fc16
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-cli-1.2.2-3.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-23 11:05:10
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-cli-1.2.2-3.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-cli-1.2.2-3.fc16 has been pushed to the Fedora 16 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-cli-1.2.2-3.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org