https://bugzilla.redhat.com/show_bug.cgi?id=2283849
Bug ID: 2283849 Summary: Review Request: rust-rusty_paserk - Platform Agnostic Serializable Keys Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@lecris.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/LecrisUT/rusty_parserk-paseto-rpmspec/raw/3c3f0e08e67ae68... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rusty_par... Description: Dependency for `atuin` Fedora Account System Username: lecris
rust2rpm.toml ```toml [[package.extra-patches]] comments = [ "Relax libtest-mimic dependency", ] file = "rust-rusty_paserk-0.4.0-Relax_dependencies.diff" number = 10 ```
https://bugzilla.redhat.com/show_bug.cgi?id=2283849
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2283850, 2258880
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2258880 [Bug 2258880] Review Request: rust-argon2 - Pure Rust implementation of the Argon2 password hashing function https://bugzilla.redhat.com/show_bug.cgi?id=2283850 [Bug 2283850] Review Request: rust-rusty_paseto - rust-rusty_paseto
https://bugzilla.redhat.com/show_bug.cgi?id=2283849
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ru | |sty_paserk
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7504972 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2283849
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |zebob.m@gmail.com CC| |zebob.m@gmail.com Status|NEW |POST Flags| |fedora-review+
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - use rust2rpm -p and document the patch
# Manually created patch for downstream crate metadata changes # * Relax libtest-mimic dependency Patch: rusty_paserk-fix-metadata.diff # Manually created patch for downstream crate metadata changes # * Relax libtest-mimic dependency Patch: rusty_paserk-fix-metadata.diff
--- rusty_paserk-0.4.0/Cargo.toml 1970-01-01T00:00:01+00:00 +++ rusty_paserk-0.4.0/Cargo.toml 2024-06-02T05:51:42.204196+00:00 @@ -141,7 +141,7 @@ version = "0.4"
[dev-dependencies.libtest-mimic] -version = "0.7.3" +version = ">=0.6.1"
[dev-dependencies.rand] version = "0.8"
Rust Package Review
This package was generated using rust2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[x] The latest version is packaged or packaging an earlier version is justified. [x] The License tag reflects the package contents and uses the correct identifiers. [x] The package builds successfully in mock. [x] Package is installable (checked by fedora-review). [x] There are no relevant rpmlint errors. [x] The package runs tests in %check. [x] The package's binaries don't conflict with binaries already in the distribution. [x] There are no %{_bindir}/* wildcards in %files. [x] The package complies with the Rust and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
[ ] Add the package to release-monitoring.org [ ] Add the package to Koschei [ ] Give rust-sig privileges (at least commit) on the package [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
package-review@lists.fedoraproject.org