https://bugzilla.redhat.com/show_bug.cgi?id=823332
Bug ID: 823332 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: rubygem-mixlib-log Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: rpms@courteau.org Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: https://raw.github.com/jcourteau/rubygems-rpms/master/fc17/rubygem-mixlib-lo... SRPM URL: http://rpms.courteau.org/fedora/rubygem-mixlib-log-1.3.0-1.fc17.src.rpm
Description: A gem that provides a simple mixin for log functionality.
This is part of a set of dependencies for rubygem-chef. I've got about 14 packages to add, all ruby gems, and am looking for a sponsor. Several of the packages were previously in Fedora (F11 and F12), but were removed due to lack of a maintainer.
https://bugzilla.redhat.com/show_bug.cgi?id=823332
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |823352
https://bugzilla.redhat.com/show_bug.cgi?id=823332
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841
https://bugzilla.redhat.com/show_bug.cgi?id=823332
Jonas Courteau rpms@courteau.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rubygem-mixlib-log |rubygem-mixlib-log - Ruby | |mixin for simple log | |functionality
https://bugzilla.redhat.com/show_bug.cgi?id=823332
Jonas Courteau rpms@courteau.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 |823344
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jdunn@aquezada.com, | |jstribny@redhat.com
--- Comment #1 from Josef Stribny jstribny@redhat.com --- * There is a newer upstream version out [1]. In Fedora we try to stay with the latest upstream version when possible.
* Specs should be included in the -doc subpackage Note: specs are already included in the latest version of the gem [1]
* %check section should ran also other specs that come with the 1.4.1
* The Ruby runtime dependency needs to be dropped in order to support multiple Ruby implementations in Fedora 19 - delete Requires: ruby
[1] http://rubygems.org/gems/mixlib-log/versions/1.4.1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |823331
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #2 from Julian C. Dunn jdunn@aquezada.com --- (In reply to comment #1)
- There is a newer upstream version out [1]. In Fedora we try to stay with
the latest upstream version when possible.
Specs should be included in the -doc subpackage Note: specs are already included in the latest version of the gem [1]
%check section should ran also other specs that come with the 1.4.1
The Ruby runtime dependency needs to be dropped in order to support
multiple Ruby implementations in Fedora 19
- delete Requires: ruby
All done. Please see here for updated spec and SRPM:
http://jdunn.fedorapeople.org/rubygem-mixlib-log/rubygem-mixlib-log.spec http://jdunn.fedorapeople.org/rubygem-mixlib-log/rubygem-mixlib-log-1.4.1-1....
I had some issues getting the conditional macro to work in %check for EL6 (rspec is too old on EL6 to run the tests). What's in the spec now works, but it's ugly. Ideally I would just like to do something like
%if %{!?el6} # run tests in here %endif
but that didn't work.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |jstribny@redhat.com
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Josef Stribny jstribny@redhat.com --- Thank you Julian.
* There is no need to exclude %{gem_instdir}/spec if you are listing it later in %files doc. -- Leave the file in the %files doc section and remove the exclusion of the file in %files
* Files README.rdoc and NOTICE could be probably placed in the -doc subpackage as they are not needed for runtime. -- Please consider moving them to the -doc subpackage
* Additionally, you can consider keeping Rakefile in the -doc subpackage as well.
Otherwise it looks good. Rpmlint gave me no errors and the package builds in Koji so I am APPROVING the package. Please fix the issues before pushing.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #4 from Julian C. Dunn jdunn@aquezada.com --- Will do, thanks for the review, Josef.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
Julian C. Dunn jdunn@aquezada.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Julian C. Dunn jdunn@aquezada.com --- Package Change Request ====================== Package Name: rubygem-mixlib-log New Branches: f16 f17 f18 Owners: jdunn InitialCC:
Undeprecate package.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-log-1.4.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-mixlib-log-1.4.1-3.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-log-1.4.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-mixlib-log-1.4.1-3.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-log-1.4.1-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-mixlib-log-1.4.1-3.fc16
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-log-1.4.1-3.fc17 has been pushed to the Fedora 17 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-23 11:04:38
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-log-1.4.1-3.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-log-1.4.1-3.fc16 has been pushed to the Fedora 16 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- rubygem-mixlib-log-1.4.1-3.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org