Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878430
--- Comment #3 from Bohuslav "Slavek" Kabrda <bkabrda(a)redhat.com> ---
(In reply to comment #2)
* Do not initiate the git repository
- I guess that the "git init" could be avoided, if the Gemfile is removed
for the test.
Fixed
* Why are you dropping entire spec directory?
- Since it is not required for runtime, we keep in in -doc subpackage
typically
Done
* File permissions
- You are fixing few file permissions in %install section. Since this is
very
likely an upstream error, have you reported it upstream (I see no
relevant
notice anywhere)?
I discussed with upstream and changed the permissions stuff a little. See
https://github.com/Pajk/apipie-rails/issues/70
* Missing runtime dependencies
- Seems that you are entirely missing runtime dependencies.
irb(main):001:0> require 'apipie-rails'
NameError: uninitialized constant ActionDispatch
Actually, this gem is only meant to work with initialized rails app. I added
Requires: rubygem(rails) and tested with the config mentioned in README.rdoc
file (but I removed the "config.markup..." line, as it would require more deps,
which are optional). So with a minimal rails app, the gem works, otherwise it
doesn't really make sense.
* License
- jquery-1.7.2.js is dual licensed under the MIT or GPL Version 2 licenses.
Indeed. Fixed.
Note, that rpmlint is still complaining about errors with two zero-length
files, but I consider them to be false positives.
SPEC:
http://bkabrda.fedorapeople.org/pkgs/apipie-rails/rubygem-apipie-rails.spec
SRPM:
http://bkabrda.fedorapeople.org/pkgs/apipie-rails/rubygem-apipie-rails-0....
--
You are receiving this mail because:
You are on the CC list for the bug.