Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=565502
Dave Malcolm <dmalcolm(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dmalcolm(a)redhat.com
--- Comment #2 from Dave Malcolm <dmalcolm(a)redhat.com> 2010-02-15 17:13:05 EST ---
(Not sure I'll have time for a full review, am getting ready for PyCon; but
here are some things I spotted)
The URL seems to be for recaptcha as a whole, and I found it hard to find info
on the client; I suggest changing the URL field to this:
http://pypi.python.org/pypi/recaptcha-client
Initial review of specfile seems sane, with some issues noted below:
Please do a scratch build in Koji.
Please run rpmlint on the packages; looks like the %description needs to be
line-wrapped, at least:
python-recaptcha-client.noarch: E: description-line-too-long Provides a CAPTCHA
for Python using the reCAPTCHA service. Does not require any imaging libraries
because the CAPTCHA is served directly from reCAPTCHA. Also allows you to
securely obfuscate emails with Mailhide. This functionality requires pycrypto.
This library requires two types of API keys. If you'd like to use the CAPTCHA,
you'll need a key from
http://recaptcha.net/api/getkey. For Mailhide, you'll
need a key from
http://mailhide.recaptcha.net/apikey.
python-recaptcha-client.noarch: W: invalid-license X11
python-recaptcha-client.noarch: W: no-documentation
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
description-line-too-long: please fix this
python-recaptcha-client.noarch: W: invalid-license X11: is there any license
information on this code other that the reference in the setup.py and on the
pypi web site?
python-recaptcha-client.noarch: W: no-documentation: I don't see any
documentation in the tarball, so I think this can be waived
BTW, which releases are you targetting? Rawhide and EPEL5?
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.