https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Bug ID: 2031370 Summary: Review Request: rit-meeranew-fonts - OpenType fonts for Malayalam Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rajeeshknambiar@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-meeranew-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-meeranew-fonts-1.2-1.fc35.... Description: A sans serif font for Malayalam Fedora Account System Username: rajeeshknambiar
Note: this obsoletes smc-meera-fonts (as discussed with vvijayara and pravins)
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Rajeesh rajeeshknambiar@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pnemade@redhat.com, | |vvijayra@redhat.com Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Parag Nemade pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|pnemade@redhat.com |
--- Comment #1 from Parag Nemade pnemade@redhat.com --- I prefer different bugzilla account for package reviews.
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |panemade@gmail.com CC| |panemade@gmail.com
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- Review Suggestion: 1) When new font packaging approved in Fedora, 'fontpackages' got obsoleted by 'fonts-rpm-macros' package. Hence, drop below from SPEC file BuildRequires: fontpackages-devel Requires: fontpackages-filesystem
2) Change below from %global fontfamily meeranew to %global fontfamily Meera New
Font Family name is "Meera New" and not "MeeraNew". Please note <SPACE> character. Thus it makes packages name as rit-meera-new-fonts.
3) You should add config file path by correcting below line %global fontconfs %{nil}
4) SPEC file shows %global fontappstreams in.org.rachana.meeranew.metainfo.xml fix this to %global fontappstreams meta/in.org.rachana.meeranew.metainfo.xml
I think here upstream should actually use file name as in.org.rachana.meera-new.metainfo.xml. This is based on the way you named other font appstream file for " rit-rachana-fonts" in.org.rachana.rit-rachana.metainfo.xml where fontfamily is "RIT Rachana".
Submit new package SPEC and SRPM.
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
--- Comment #3 from Rajeesh rajeeshknambiar@gmail.com --- Thanks for the review comments, Parag!
Addressed all the comments (and also released a new upstream version).
Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-meera-new-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-meera-new-fonts-1.2.1-0.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Parag AN(पराग) panemade@gmail.com --- The only thing remaining here is that this new package is not obsoleting existing smc-meera-fonts package. Fix this by changing Obsoletes: smc-meera-fonts <= 7.0 to Obsoletes: smc-meera-fonts <= 7.0.3
Rest looks good to me.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
--- Comment #5 from Rajeesh rajeeshknambiar@gmail.com --- Thank you.
A slight problem when I do `fedpkg request-repo` with updated name `rit-meera-new-fonts` not matching with bugzilla entry name (`meeranew`). Should I abandon this request and create another one?
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rit-meeranew-fonts - |rit-meera-new-fonts - |OpenType fonts for |OpenType fonts for |Malayalam |Malayalam
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- Sorry I forgot to tell here that the package name need to be updated. When you do request-repo then the package <name> need to be matched with this bug's title. I have corrected it. Please try again request-repo.
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rit-meera-new-fonts - |rit-meera-new-fonts - Open |OpenType fonts for |Type body text font for |Malayalam |Malayalam traditional | |script
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
--- Comment #7 from Parag AN(पराग) panemade@gmail.com --- One more thing I realized the fontconfig file contains font family name as "MeeraNew". Change it to "Meera New".
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
--- Comment #8 from Rajeesh rajeeshknambiar@gmail.com --- (In reply to Parag AN(पराग) from comment #7)
One more thing I realized the fontconfig file contains font family name as "MeeraNew". Change it to "Meera New".
Yes, that is fixed in new upstream version.
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
--- Comment #9 from Parag AN(पराग) panemade@gmail.com --- (In reply to Rajeesh from comment #8)
(In reply to Parag AN(पराग) from comment #7)
One more thing I realized the fontconfig file contains font family name as "MeeraNew". Change it to "Meera New".
Yes, that is fixed in new upstream version.
Thanks
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Rajeesh rajeeshknambiar@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gwync@protonmail.com Flags| |needinfo?(gwync@protonmail. | |com)
--- Comment #10 from Rajeesh rajeeshknambiar@gmail.com --- @gwync@protonmail.com
I still cannot push to the repository as I'm not a member (see https://pagure.io/releng/fedora-scm-requests/issue/40013#comment-771409)
Could you take a look?
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Gwyn Ciesla gwync@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(gwync@protonmail. | |com) |
--- Comment #11 from Gwyn Ciesla gwync@protonmail.com --- Transferred ownership.
https://bugzilla.redhat.com/show_bug.cgi?id=2031370
Rajeesh rajeeshknambiar@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-12-31 07:44:30
package-review@lists.fedoraproject.org