Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770134
Kevin Fenzi <kevin(a)scrye.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Kevin Fenzi <kevin(a)scrye.com> 2011-12-24 17:08:14 EST ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
Issues:
1. Not a blocker, but you might ask upstream to include a copy of the BSD
license with the package.
2. rpmlint says:
trac-workflowadmin-plugin.noarch: W: spelling-error Summary(en_US) workflow ->
work flow, work-flow, workforce
trac-workflowadmin-plugin.noarch: W: spelling-error %description -l en_US
workflow -> work flow, work-flow, workforce
trac-workflowadmin-plugin.noarch: W: no-documentation
trac-workflowadmin-plugin.src: W: spelling-error Summary(en_US) workflow ->
work flow, work-flow, workforce
trac-workflowadmin-plugin.src: W: spelling-error %description -l en_US workflow
-> work flow, work-flow, workforce
trac-workflowadmin-plugin.src: W: invalid-url Source0:
trac-workflowadmin-plugin-0.12.svn11020.tar.gz
all can be ignored.
I don't see any blockers here, so this package is APPROVED.
Happy to co-maintain.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.