https://bugzilla.redhat.com/show_bug.cgi?id=785496
Shawn Iwinski <shawn.iwinski(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora(a)famillecollet.com,
| |shawn.iwinski(a)gmail.com
--- Comment #1 from Shawn Iwinski <shawn.iwinski(a)gmail.com> ---
I am not an official package reviewer, but here are some comments I have for
this package:
*** It would help readability to group your Build* and Requires* statements
together instead of mixing them with each other and your Provides and Conflicts
statements
*** Your BuildRequires should be
BuildRequires: php-pear(PEAR) >= 1.7.0
instead of
BuildRequires: php-pear >= 1:1.4.9-1.2
(this would match what you have in bug 785606 and satisfy this package's
package.xml dependency)
*** Your Provides statement should be
Provides:
php-pear(pear.horde.org/%{pear_name}) = %{version}
instead of
Provides: php-pear(%{pear_name}) = %{version}
*** phpci results: For completeness (and to prevent any future packaging issues
due to PHP package changes), you may wish to require the virtual provide
"php-date".
*** Do you plan on building for EPEL 5?
- If not, please remove "rm -rf $RPM_BUILD_ROOT" from the %install section (see
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag).
- If you do, there are several staements that need to be added.
--
You are receiving this mail because:
You are on the CC list for the bug.