https://bugzilla.redhat.com/show_bug.cgi?id=2026815
Bug ID: 2026815 Summary: Review Request: rust-self_cell - Safe-to-use proc-macro-free self-referential structs in stable Rust Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: link@sub-pop.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... Description: Safe-to-use proc-macro-free self-referential structs in stable Rust Fedora Account System Username: linkdupont Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Status|NEW |ASSIGNED
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Package looks good to me, with one flaw from the upstream project ...
Both the LICENSE and the README.md file are implicitly excluded from published crates: https://github.com/Voultapher/self_cell/blob/main/Cargo.toml#L16
Please open an issue or PR with upstream to explicitly include at least the LICENSE file. The terms of the Apache-2.0 license require redistributed sources to contain the license text.
You can either wait until this is rectified in a new upstream release, or include the LICENSE file from github manually, until the first one happens: https://github.com/Voultapher/self_cell/blob/v0.10.1/LICENSE
Either of those is acceptable here, and I'll finish the review once either are done.
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
--- Comment #2 from Link Dupont link@sub-pop.net --- I opened a PR[1] upstream to include the license in the crate. I also updated the spec to include the license as a second source file an drop it into the build directory during %prep so that it's included in the files list.
1: https://github.com/Voultapher/self_cell/pull/34
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
--- Comment #3 from Link Dupont link@sub-pop.net --- Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Looks good to me. Please add a comment with a link to the PR mentioned in Comment 2. Alternatively, package 0.10.2 directly, it should contain the files we need.
Other than that:
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged (0.10.2 is code-identical to 0.10.1, but included the LICENSE file we want) - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
--- Comment #5 from Igor Raits igor.raits@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-self_cell
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2026815
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2021-12-11 01:31:22
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org