https://bugzilla.redhat.com/show_bug.cgi?id=1644266
Jitka Plesnikova <jplesnik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova <jplesnik(a)redhat.com> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
$ rpm -qp --requires perl-Sentry-Raven-1.10-1.fc30.noarch.rpm | sort | uniq -c
1 perl(constant)
1 perl(Data::Dump)
1 perl(Devel::StackTrace)
1 perl(English)
1 perl(File::Basename)
1 perl(HTTP::Request::Common)
1 perl(HTTP::Status)
1 perl(JSON::XS)
1 perl(LWP::Protocol::https)
1 perl(LWP::UserAgent)
1 perl(:MODULE_COMPAT_5.28.0)
1 perl(Moo)
1 perl(MooX::Types::MooseLike::Base)
1 perl(strict)
1 perl(Sys::Hostname)
1 perl(Time::Piece)
1 perl(URI)
1 perl(UUID::Tiny)
1 perl(:VERSION) >= 5.8.0
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -qp --provides perl-Sentry-Raven-1.10-1.fc30.noarch.rpm | sort | uniq -c
1 perl(Sentry::Raven) = 1.10
1 perl-Sentry-Raven = 1.10-1.fc30
1 perl(Sentry::Raven::Processor::RemoveStackVariables)
Binary provides are Ok.
$ rpmlint ./perl-Sentry-Raven*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok
BuildRequires
FIX: Please add build-requires
- coreutils - because 'rm' is used in spec file
- findutils - 'find' is used in spec file
- make - is used in spec file
- perl-interpreter or %{__perl} - it is used in spec file
If you want to add the package to EPEL, please ignore these two TODO
TODO: The easier way to remove .packlist is used NO_PACKLIST option,
which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be
used in all Fedoras. The command is
%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
TODO: Remove the deleting empty directories in %install section. This is
default behavior for Fedoras.
Please correct all 'FIX' issues and consider fixing 'TODO' items.
Otherwise the package looks good.
Approved
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component