https://bugzilla.redhat.com/show_bug.cgi?id=1004094
Orion Poplawski <orion(a)cora.nwra.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|package-review(a)lists.fedora |
|project.org |
--- Comment #2 from Orion Poplawski <orion(a)cora.nwra.com> ---
(In reply to Christopher Meng from comment #1)
Improvement:
1. Avoid attr() nowadays. Please correc its permission when installing it:
install -pm755 cups-x2go %{buildroot}%{_prefix}/lib/cups/backend/
2. Drop %doc as it doesn't exist.
3. %{_sysconfdir}/cups/cups-x2go.conf
should be added %config(noreplace)
All fixed.
4. New Fedora Review tool is very nice, it told me that you
shouldn't own a
dir already taken by other packages:
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/x2go(x2goserver),
/usr/share/x2go/versions(x2goserver)
So you should correct %{_datadir}/x2go/.
The problem is the cups-x2go can be installed independently of x2goserver, so
they both need to own it.
5. cups-x2go.noarch: W: non-standard-group Server
So, fix it or drop the group tag.
Fixed - kept for EL6
6. cups-x2go.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line
11, tab:
line 1)
Fixed
* Wed Sep 4 2012 Orion Poplawski <orion(a)cora.nwra.com> 3.0.0.4-2
- Use install to set permissions on cups-x2go
- Drop %%doc for now
- Mark config file as %%config(noreplace)
- Fix Group
- Drop tabs
http://www.cora.nwra.com/~orion/fedora/nx/cups-x2go.spec
http://www.cora.nwra.com/~orion/fedora/nx/cups-x2go-3.0.0.4-2.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=eAgzz6M5fL&a=cc_unsubscribe