https://bugzilla.redhat.com/show_bug.cgi?id=1119075
--- Comment #2 from Igor Gnatenko <i.gnatenko.brain(a)gmail.com> ---
(In reply to Jon Ciesla from comment #1)
Build error. .
chmod: cannot access '/etc/httpd//conf.d/itop-itsm.conf': No such file or
directory
https://sourceforge.net/p/itop/tickets/961/
Patch there.
- rpmlint checks return:
itop-itsm.noarch: W: non-conffile-in-etc /etc/httpd/conf.d/itop-itsm.conf
itop-itsm.noarch: W: non-conffile-in-etc /etc/cron.d/itop-itsm
A non-executable file in your package is being installed in /etc, but is not
a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.
fixed.
itop-itsm.noarch: E: incorrect-fsf-address
/usr/share/itop-itsm/datamodels/2.x/itop-virtualization-mgmt/en.dict.itop-
virtualization-mgmt.php
itop-itsm.noarch: E: incorrect-fsf-address
/usr/share/itop-itsm/datamodels/2.x/itop-endusers-devices/module.itop-
endusers-devices.php
itop-itsm.noarch: E: incorrect-fsf-address
/usr/share/itop-itsm/datamodels/2.x/itop-endusers-devices/en.dict.itop-
endusers-devices.php
itop-itsm.noarch: E: incorrect-fsf-address
/usr/share/itop-itsm/datamodels/2.x/itop-storage-mgmt/module.itop-storage-
mgmt.php
itop-itsm.noarch: E: incorrect-fsf-address
/usr/share/itop-itsm/datamodels/2.x/itop-storage-mgmt/en.dict.itop-storage-
mgmt.php
itop-itsm.noarch: E: incorrect-fsf-address
/usr/share/itop-itsm/datamodels/2.x/itop-virtualization-mgmt/module.itop-
virtualization-mgmt.php
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license
file,
possibly the entire file with a new copy available from the FSF.
informed.
https://sourceforge.net/p/itop/tickets/959/
itop-itsm.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/itop-itsm/README
itop-itsm.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/itop-itsm/LICENSE
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.
fixed and informed upstream.
https://sourceforge.net/p/itop/tickets/960/
itop-itsm.noarch: W: log-files-without-logrotate /var/log/itop-itsm
This package contains files in /var/log/ without adding logrotate
configuration for them.
https://sourceforge.net/p/itop/tickets/962/
patch there.
These should all be fixed.
- package meets naming guidelines
- package meets packaging guidelines
- license ( AGPLv3+, MIT, LGPLv3) OK, text in %doc, matches source
- spec file legible, in am. english
# jQuery and it's modules has MIT and now it's not available for Fedora
What is not available for Fedora? Not clear.
http://pkgs.fedoraproject.org/cgit/?q=jquery
I can't find js-jquery package. It should be added by F21 Change.
review for js-jquery here. bug 1078368
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Bundles swiftmailer which should be packaged on it's own, reviewed, and then
this package should be patched to use it.
we have old swiftmailer in repos, so
I'm working to update it.
# Fedora has 5.0.2
# After updating Fedora to 5.2.1 I will prepare patches and drop bundle
Provides: bundled(php-swift-Swift) = 4.1.2
Was this approved by FPC? If so add link to Trac in spec.
No, not yet. I wanted
first to fix other issues. I will fix this in this week.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component