Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ktp-send-file - A File manager plugin to launch a file transfer job with a specified contact
https://bugzilla.redhat.com/show_bug.cgi?id=784956
Summary: Review Request: ktp-send-file - A File manager plugin to launch a file transfer job with a specified contact Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-send-file.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-send-file-0.3.0-1.fc1... Description: A File manager plugin to launch a file transfer job with a specified contact
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |784945 Blocks| |784939(kde-telepathy-0.3), | |656997(kde-reviews)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |alekcejk@googlemail.com AssignedTo|nobody@fedoraproject.org |alekcejk@googlemail.com Flag| |fedora-review?
--- Comment #1 from nucleo alekcejk@googlemail.com 2012-02-06 21:13:09 EST --- Summary: A File manager plugin to launch a file transfer job with a specified contact. Is this summary not too long?
# service menu only, desktop validation not required # in a perfect world, this would get moved to datadir/kde4/services/ %{_kde4_datadir}/applications/kde4/ktp-send-file.desktop
So can be moved to services dir? This can fix rpmlint errors: ktp-send-file.i686: E: invalid-desktopfile /usr/share/applications/kde4/ktp-send-file.desktop (will be fatal in the future): value "all/allfiles;" for key "MimeType" in group "Desktop Entry" contains value "all/allfiles" which is an invalid MIME type: "all" is an unregistered media type ktp-send-file.i686: E: invalid-desktopfile /usr/share/applications/kde4/ktp-send-file.desktop required key "Name" in group "Desktop Entry" is not present ktp-send-file.i686: E: invalid-desktopfile /usr/share/applications/kde4/ktp-send-file.desktop key "MimeType" is present in group "Desktop Entry", but the type is "Service" while this key is only valid for type "Application"
%find_lang %{name} --all-name --with-kde %find_lang works here without --all-name
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
--- Comment #2 from nucleo alekcejk@googlemail.com 2012-02-06 21:19:23 EST --- BuildRequires: desktop-file-utils is not needed if it not used.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
--- Comment #3 from nucleo alekcejk@googlemail.com 2012-02-06 21:44:17 EST --- BuildRequires: telepathy-qt4-devel also not needed because ktp-common-internals-devel requires it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |ktp-send-file - A File |ktp-send-file - A File |manager plugin to launch a |manager plugin to launch |file transfer job with a |file transfer jobs |specified contact |
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2012-02-07 08:53:32 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-send-file.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-send-file-0.3.0-1.fc1...
%changelog * Tue Feb 07 2012 Rex Dieter rdieter@fedoraproject.org 0.3.0-2 - shorten Summary - drop BR: desktop-file-utils telepathy-qt4-devel
Re: %find_lang %{name} --all-name --with-kde %find_lang works here without --all-name
true, but I'd rather be safe and have it automatically include HTML handbooks if they ever get included upstream.
Re: So can be moved to services dir? I think I tried that, and it didn't work. Besides, rpmlint should probably be fixed to only operate on .desktop files containing Type=Application (which is not the case here)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from nucleo alekcejk@googlemail.com 2012-02-07 09:35:41 EST --- name: ok summary: ok license: ok BuildRequires: ok Obsoletes/Provides: ok handling locale files: ok
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
--- Comment #6 from Michael Schwendt mschwendt@gmail.com 2012-02-09 10:04:58 EST ---
summary: ok
No, it isn't "ok" for various reasons:
Name: ktp-send-file Summary: A File manager plugin to launch file transfer jobs
While the big 'F' in "File manager" may be just a typo, one wonders _which file manager_ is this for? Summaries without leading articles also are more readable, btw.
%description %{summary}.
The same that I've added to bug 784950 applies here.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC|alekcejk@googlemail.com | AssignedTo|alekcejk@googlemail.com |nobody@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
Bug 784956 depends on bug 784945, which changed state.
Bug 784945 Summary: Review Request: ktp-common-internals - Common internals for KDE Telepathy https://bugzilla.redhat.com/show_bug.cgi?id=784945
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|NEW |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Rex Dieter rdieter@math.unl.edu 2012-02-09 13:52:35 EST --- I'll look into improving the description prior to doing any builds, thanks.
New Package SCM Request ======================= Package Name: ktp-send-file Short Description: A File manager plugin to launch file transfer jobs Owners: jreznik rdieter Branches: f16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
--- Comment #8 from Jon Ciesla limburgher@gmail.com 2012-02-09 13:58:59 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |alekcejk@googlemail.com AssignedTo|nobody@fedoraproject.org |alekcejk@googlemail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784956
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2012-02-10 17:09:20
--- Comment #9 from Rex Dieter rdieter@math.unl.edu 2012-02-10 17:09:20 EST --- imported
package-review@lists.fedoraproject.org