Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppisar(a)redhat.com> 2012-01-16 07:57:28 EST ---
Spec file changes:
--- perl-LWP-Protocol-http10.spec 2011-05-31 11:52:07.000000000 +0200
+++ perl-LWP-Protocol-http10.spec.1 2012-01-16 08:53:32.000000000 +0100
@@ -1,6 +1,6 @@
Name: perl-LWP-Protocol-http10
Version: 6.02
-Release: 1%{?dist}
+Release: 3%{?dist}
Summary: Legacy HTTP/1.0 support for LWP
License: GPL+ or Artistic
Group: Development/Libraries
@@ -11,21 +11,19 @@
BuildRequires: perl(HTTP::Response) >= 6
BuildRequires: perl(HTTP::Status) >= 6
BuildRequires: perl(LWP::Protocol) >= 6
+
Requires: perl(HTTP::Response) >= 6
+%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}^perl\\(HTTP::Response\\)
Requires: perl(HTTP::Status) >= 6
+%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}^perl\\(HTTP::Status\\)
Requires: perl(LWP::Protocol) >= 6
+%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}^perl\\(LWP::Protocol\\)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
-
-%{?filter_setup:
-# Filter unversioned versions of versioned Requires:
-%filter_from_requires /^perl(HTTP::Response)/d
-%filter_from_requires /^perl(HTTP::Status)/d
-%filter_from_requires /^perl(LWP::Protocol)/d
-%?perl_default_filter
-}
+# Make optional dependency mandatory
+Requires: perl(URI::Escape)
%description
-The LWP::Protocol::http10 module provide support for using HTTP/1.0
+The LWP::Protocol::http10 module provides support for using HTTP/1.0
protocol with LWP. To use it you need to call LWP::Protocol::implementor()
to override the standard handler for http URLs.
@@ -54,6 +52,11 @@
%{_mandir}/man3/*
%changelog
-* Tue May 31 2011 Ralf Corsépius <corsepiu(a)fedoraproject.org> 6.02-1
-- Initial Fedora package.
+* Mon Jan 16 2012 Ralf Corsépius <corsepiu(a)fedoraproject.org> 6.02-3
+- Rework filters.
+
+* Fri Jun 19 2011 Ralf Corsépius <corsepiu(a)fedoraproject.org> 6.02-2
+- Reflect feedback from package review.
+* Mon Apr 18 2011 Ralf Corsépius <corsepiu(a)fedoraproject.org> 6.02-1
+- Specfile autogenerated by cpanspec 1.78.
TODO: Description contains orthographic mistake: `module _provide_
support'.
There should be `provides'.
%description
-The LWP::Protocol::http10 module provide support for using HTTP/1.0
+The LWP::Protocol::http10 module provides support for using HTTP/1.0
Ok.
TODO: No tests are presented, thus the package in question is not
executed at
build time. You can remove all BuildRequires except perl(ExtUtils::MakeMaker).
Not
addressed. Ok.
TODO: Remove %defattr from %files section as this is implicit
already.
Not addressed. Ok.
$ rpmlint perl-LWP-Protocol-http10.spec
../SRPMS/perl-LWP-Protocol-http10-6.02-3.fc17.src.rpm
../RPMS/noarch/perl-LWP-Protocol-http10-6.02-3.fc17.noarch.rpm
perl-LWP-Protocol-http10.src: W: spelling-error %description -l en_US
implementor -> implementer, implement or, implement-or
perl-LWP-Protocol-http10.src: W: spelling-error %description -l en_US http ->
HTTP
perl-LWP-Protocol-http10.noarch: W: spelling-error %description -l en_US
implementor -> implementer, implement or, implement-or
perl-LWP-Protocol-http10.noarch: W: spelling-error %description -l en_US http
-> HTTP
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint Ok.
FIX: Require perl(URI::Escape) (lib/LWP/Protocol/http10.pm:74).
+# Make optional dependency mandatory
+Requires: perl(URI::Escape)
Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-LWP-Protocol-http10-6.02-3.fc17.noarch.rpm |sort |uniq -c
1 perl(HTTP::Response) >= 6
1 perl(HTTP::Status) >= 6
1 perl(IO::Select)
1 perl(IO::Socket)
1 perl(LWP::Protocol) >= 6
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(strict)
1 perl(URI::Escape)
1 perl(vars)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-LWP-Protocol-http10-6.02-3.fc17.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F17
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=3705662). Ok.
Resolution: Package APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.