Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924750
--- Comment #3 from Petr Šabata <psabata(a)redhat.com> ---
(In reply to comment #2)
(In reply to comment #1)
> This is a noarch package, you don't need to define the OPTIMIZE variable.
> Line 57 is also unnecessary.
>
> Style nitpicking: capitalize 'requires' on line 37.
>
Fixed.
Ack. Approving.
> Even though META.yml lists ExtUtils::MakeMaker as a runtime
dependency, I
> can't really tell how it's used. Similarly, could you explain the
> perl-devel dependency? This package doesn't do any actual C compiling.
perl-devel provides Perl header files that are needed by C files generated
by this module to compile them. So I required perl-devel because there is
currently no clear decision which packages should require it. (We use the
same approach at ExtUtils-MakeMaker and Module-Build.)
I guess the correct way to handle this would be BR'ing perl-devel in every XS
perl package. Well, that's not the situation we're in at the moment so I
suppose having perl-devel required here is a good thing... for now.
Dependency on ExtUtils::MakeMaker is a remnant of META.yml probably.
I know
there are same disputes how MakeMaker uses ParseXS, so that could have been
the reason.
What's your opinion? Should I drop the perl-devel and EU::MM run-time
dependencies?
I'd drop EU::MM from the runtime dep list.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Trc24WJDpU&a=cc_unsubscribe