Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=423631
Summary: Review Request: sugar-evince - evince package for OLPC, library for embedding Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: reinier@heeres.eu QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://dev.laptop.org/~rwh/sugar-evince.spec SRPM URL: http://dev.laptop.org/~rwh/sugar-evince-2.20.0-1.src.rpm Description: evince is a GNOME-based document viewer. This is the version developed for OLPC. It is built as a library to support embedding.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sugar-evince - evince package for OLPC, library for embedding
https://bugzilla.redhat.com/show_bug.cgi?id=423631
mpg@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mpg@redhat.com
------- Additional Comments From mpg@redhat.com 2007-12-18 07:45 EST ------- It doesn't build on x86_64. I uploaded a new spec here with that fixed.
http://dev.laptop.org/~marco/sugar-evince.spec
rpmlint output:
[marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-2.20.0-1.x86_64.rpm sugar-evince.x86_64: W: no-documentation sugar-evince.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libevince.so sugar-evince.x86_64: E: library-without-ldconfig-postin /usr/lib64/libevince.so.0.0.0 sugar-evince.x86_64: E: library-without-ldconfig-postun /usr/lib64/libevince.so.0.0.0 sugar-evince.x86_64: E: description-line-too-long evince is a GNOME-based document viewer. This is the version developed for OLPC. sugar-evince.x86_64: W: invalid-license GPL [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/SRPMS/sugar-evince-2.20.0-1.src.rpm sugar-evince.src: W: mixed-use-of-spaces-and-tabs (spaces: line 33, tab: line 5) sugar-evince.src: E: description-line-too-long evince is a GNOME-based document viewer. This is the version developed for OLPC. sugar-evince.src: W: invalid-license GPL [marco@localhost SPECS]$ scp sugar-evince.spec dev.laptop.org:~/marco/public_html [marco@localhost SPECS]$ scp sugar-evince.spec dev.laptop.org:~/public_html sugar-evince.spec 100% 2251 2.2KB/s 00:00 [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/SRPMS/sugar- sugar-0.70.4-1.src.rpm sugar-datastore-0.2.3-1.src.rpm sugar-evince-2.20.0-1.src.rpm [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-python-2.20.0-1.x86_64.rpm sugar-evince-python.x86_64: W: no-documentation sugar-evince-python.x86_64: W: invalid-license GPL [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-debuginfo-2.20.0-1.x86_64.rpm sugar-evince-debuginfo.x86_64: W: invalid-license GPL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sugar-evince - evince package for OLPC, library for embedding
https://bugzilla.redhat.com/show_bug.cgi?id=423631
------- Additional Comments From reinier@heeres.eu 2007-12-18 08:49 EST ------- Updated spec file at link, remaining rpmlint output:
[marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-2.20.0-1.x86_64.rpm sugar-evince.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libevince.so sugar-evince.x86_64: W: invalid-license GFDL+ sugar-evince.x86_64: W: one-line-command-in-%post /sbin/ldconfig sugar-evince.x86_64: W: one-line-command-in-%postun /sbin/ldconfig [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/SRPMS/sugar-evince-2.20.0-1.src.rpm sugar-evince.src: W: invalid-license GFDL+ [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-python-2.20.0-1.x86_64.rpm sugar-evince-python.x86_64: W: no-documentation sugar-evince-python.x86_64: W: invalid-license GFDL+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sugar-evince - evince package for OLPC, library for embedding
https://bugzilla.redhat.com/show_bug.cgi?id=423631
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|mpg@redhat.com |dennis@ausil.us Flag| |fedora-review?
------- Additional Comments From dennis@ausil.us 2007-12-18 13:47 EST ------- taking a quick look mostly ok.
You need to bump release during review and include in the changelog what you fix
the URL should point to a page that has information on the wiki. and Source must be a url pointing to where source can be accessed for verification.
at Marco's request ill take the review over
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sugar-evince - evince package for OLPC, library for embedding
https://bugzilla.redhat.com/show_bug.cgi?id=423631
------- Additional Comments From reinier@heeres.eu 2007-12-19 14:45 EST ------- Updated spec and SRPM according to comments. To be found at: Spec URL: http://dev.laptop.org/~rwh/sugar-evince.spec SRPM URL: http://dev.laptop.org/~rwh/sugar-evince-2.20.0-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sugar-evince - evince package for OLPC, library for embedding
https://bugzilla.redhat.com/show_bug.cgi?id=423631
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From dennis@ausil.us 2007-12-20 23:36 EST ------- looks good now.
sha1sum matches upstream e8c8f1a1f181bd7de52baee257270adfa114c5fc evince-2.20.0.tar.bz2 e8c8f1a1f181bd7de52baee257270adfa114c5fc fedora/SOURCES/evince-2.20.0.tar.bz2
Approved
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sugar-evince - evince package for OLPC, library for embedding
https://bugzilla.redhat.com/show_bug.cgi?id=423631
mpg@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From mpg@redhat.com 2007-12-21 07:40 EST ------- New Package CVS Request ======================= Package Name: sugar-evince Short Description: OLPC version of the evince document viewer Owners: reinier@heeres.eu, mpg@redhat.com Branches: OLPC-2 InitialCC: reinier@heeres.eu, mpg@redhat.com Cvsextras Commits: no
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sugar-evince - evince package for OLPC, library for embedding
https://bugzilla.redhat.com/show_bug.cgi?id=423631
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From dennis@ausil.us 2007-12-21 08:21 EST ------- cvs done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sugar-evince - evince package for OLPC, library for embedding
https://bugzilla.redhat.com/show_bug.cgi?id=423631
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From michel.sylvan@gmail.com 2008-01-13 21:08 EST ------- Closing bug
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=423631
Tomeu Vizoso tomeu@tomeuvizoso.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomeu@tomeuvizoso.net
--- Comment #9 from Tomeu Vizoso tomeu@tomeuvizoso.net 2008-11-12 06:32:55 EDT --- Package Change Request ====================== Package Name: sugar-evince New Branches: OLPC-4 Owners: dsd mpg erikos tomeu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=423631
Tomeu Vizoso tomeu@tomeuvizoso.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=423631
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net Blocks| |462625
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=423631
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #10 from Kevin Fenzi kevin@tummy.com 2008-11-12 11:51:12 EDT --- cvs done.
package-review@lists.fedoraproject.org