Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
Bug ID: 887543 Summary: Review Request: trac-sensitivetickets-plugin - Plugin for Trac that enables sensitive tickets Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: puiterwijk@gmail.com
Spec URL: http://puiterwijk.fedorapeople.org/packages/trac-sensitivetickets-plugin/tra... SRPM URL: http://puiterwijk.fedorapeople.org/packages/trac-sensitivetickets-plugin/tra... Fedora Account System Username: puiterwijk Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4794364
Description: SensitiveTickets is a plugin that lets users mark tickets as "sensitive" with a checkbox on the ticket form. Sensitive tickets are viewable only to those with the SENSITIVE_VIEW permission.
Beware: Hooks that send mail on ticket changes will still send mail for sensitive tickets; this may not be what you want.
Beware: if the plugin is removed, disabled, or fails to load, trac will opt to display sensitive tickets ("failing open" instead of "failing closed").
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org
--- Comment #1 from Michael Scherer misc@zarb.org --- Hi,
I think the license is not very clear, could you ask to upstream to clarify ( since there is only GPL written, not GPL or later )
- python policy require to specify the version of python ( ie 2 or 3 )
- the following are not used :
%defattr(-,root,root,-) %doc
( %defattr is not needed, and empty %doc do not do anything )
- I am not sure about there release Tag http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_package...
Release: 1.svn%{svn_rev}%{?dist}
In fact, i would do 0.svn%{svn_rev}.1%(?dist} , since the svn revision is the real version and so should be used before the release tag ( which would be the 1 ).
Yet, the guideline do not seems to say that :/
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
--- Comment #2 from Patrick Uiterwijk puiterwijk@gmail.com --- Hey,
About the licensing issue: the Fedora Legal page (https://fedoraproject.org/wiki/Licensing:Main) states: "A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include.".
So according to our own wiki, it should actually be GPL+.
Also, the other things you mentioned should be fixed in this version: Spec: http://puiterwijk.fedorapeople.org/packages/trac-sensitivetickets-plugin/tra... SRPM: http://puiterwijk.fedorapeople.org/packages/trac-sensitivetickets-plugin/tra... Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4798661
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |kevin@scrye.com Flags| |fedora-review?
--- Comment #3 from Kevin Fenzi kevin@scrye.com --- I'll go ahead and review this. Look for a full review later today...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #4 from Kevin Fenzi kevin@scrye.com --- See below - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: no sha256sum, but diff of svn checkout matches. OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
Issues:
1. Do you plan on building for epel5 too? Otherwise, you can drop the first 2 lines.
2. On versioning, this is really a 'post release snapshot' no? ie, 0.21 was a version as released, but this has some svn commits after this. Really the only way to know for sure is to ask upstream, but if it's a post release snap, I would go with 'N.svn%{svn_rev}%{?dist}' where N is the increasing number for the Fedora package, until 0.22 (or whatever comes out)
3. You might also ask upstream to clarify which version of the GPL they mean and if they want to specify "or later". In the absense of that information, GPL+ should be used. You could also ask them to include a copy of the GPL COPYING file.
4. rpmlint says:
Ignore all these:
trac-sensitivetickets-plugin.noarch: W: spelling-error %description -l en_US checkbox -> check box, check-box, checkbook trac-sensitivetickets-plugin.noarch: W: spelling-error %description -l en_US viewable -> view able, view-able, viable trac-sensitivetickets-plugin.noarch: W: no-documentation trac-sensitivetickets-plugin.src: W: spelling-error %description -l en_US checkbox -> check box, check-box, checkbook trac-sensitivetickets-plugin.src: W: spelling-error %description -l en_US viewable -> view able, view-able, viable trac-sensitivetickets-plugin.src: W: invalid-url Source0: trac-sensitivetickets-plugin-0.21.svn12442.tar.gz 2 packages and 0 specfiles checked; 0 errors, 8 warnings.
Use %% for macros in "comments":
trac-sensitivetickets-plugin.src:15: W: macro-in-comment %{svn_rev} trac-sensitivetickets-plugin.src:15: W: macro-in-comment %{svn_rev}
None of those are really blockers, although we should make sure the versioning is all figured out before import, so if there's any disagreement about that, we should discuss it before importing. ;) This package is APPROVED.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
Patrick Uiterwijk puiterwijk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Patrick Uiterwijk puiterwijk@gmail.com --- New Package SCM Request ======================= Package Name: trac-sensitivetickets-plugin Short Description: Plugin for Trac that enables users to mark tickets as sensitive Owners: puiterwijk Branches: el6 f18 f17 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/trac-sensitivetickets-plugin-0.21-2....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-sensitivetickets-plugin-0.21-2....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/trac-sensitivetickets-plugin-0.21-2....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-16 14:37:11
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org