Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-cairo - Ruby bindings for cairo
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Summary: Review Request: rubygem-cairo - Ruby bindings for cairo Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mtasaka@ioa.s.u-tokyo.ac.jp QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/rubygem-cairo.s... SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/rubygem-cairo-1... Description: Ruby bindings for cairo. Cairo is a 2D graphics library with support for multiple output devices. Currently supported output targets include the X Window System, win32, and image buffers.
Note: This package will replace currently existing ruby-cairo srpm Note: This package depends on bug 634759 and bug 635126. Mockbuild log with adding these rpms for F-14 is available on
http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/MOCK-rubygem-ca...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |634759, 635126
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Bug 635302 depends on bug 635126, which changed state.
Bug 635126 Summary: Review Request: rubygem-test-unit - Improved version of Test::Unit bundled in Ruby 1.8.x https://bugzilla.redhat.com/show_bug.cgi?id=635126
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Bug 635302 depends on bug 634759, which changed state.
Bug 634759 Summary: Review Request: rubygem-pkg-config - A pkg-config implmenetation by Ruby https://bugzilla.redhat.com/show_bug.cgi?id=634759
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |637939
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |637985
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |639098
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |639636
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |639638
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mfojtik@redhat.com AssignedTo|nobody@fedoraproject.org |mfojtik@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #1 from Michal Fojtik mfojtik@redhat.com 2010-10-05 06:06:40 EDT --- Review:
[OK ]Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification. [OK] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version [OK] The package must have a Requires and a BuildRequires on rubygems [OK] The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification. [OK] The %prep and %build sections of the specfile should be empty. [-] Build is used to compile binary extension, so it's OK to this rule
[OK] The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
[OK] The install should be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} [OK] The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec
[OK] Architecture-specific content must not be installed into %{gemdir} [-] %{ruby_sitearch}/%{gemname}.so is fine here
[OK, see above] If the Gem contains binary content (e.g., for a database driver), it must be marked as architecture specific, and all architecture specific content must be moved from the %{gemdir} to the [#ruby_sitearch %{ruby_sitearch} directory] during %install
Overall it looks perfect to me, but Koji seems to fail to build this package for F13:
100% passed/builddir/build/BUILD/rubygem-cairo-1.10.0/usr/lib/ruby/gems/1.8/gems/cairo-1.10.0/test/test_context.rb:57:in `initialize': out of memory (NoMemoryError) from /builddir/build/BUILD/rubygem-cairo-1.10.0/usr/lib/ruby/gems/1.8/gems/cairo-1.10.0/test/test_context.rb:57:in `new'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-05 06:54:16 EDT --- ! About test failure on F-13 - Ah, thank you. It is found that this error occurs when no fonts are found on system.
http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/rubygem-cairo.s... http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/rubygem-cairo-1...
* Tue Oct 5 2010 Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 1.10.0-2 - Install one font at BuildRequires for test
F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2513677 F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2513680
New Package SCM Request ======================= Package Name: rubygem-cairo Short Description: Ruby bindings for cairo Owners: mtasaka Branches: f12 f13 f14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2010-10-05 09:33:23 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-05 16:51:53 EDT --- Rebuilt for F-14/13/12, requested push request on bodhi.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635302
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |NEXTRELEASE Last Closed| |2010-10-20 13:02:02
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-20 13:02:02 EDT --- Closing, thank you.
package-review@lists.fedoraproject.org