[Bug 226436] New: Merge Review: statserial

List overview All Threads
Download

newer

older

[Bug 402821] New: Review Request:...

[Bug 165960] Review Request:...

Red Hat Bugzilla

31 Jan 2007 31 Jan '07

9:02 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

Summary: Merge Review: statserial Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: twaugh@redhat.com

Fedora Merge Review: statserial

http://cvs.fedora.redhat.com/viewcvs/devel/statserial/ Initial Owner: twaugh@redhat.com

-- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Show replies by date

Red Hat Bugzilla

6 Feb 6 Feb

4:03 p.m.

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: statserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

twaugh@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?

Red Hat Bugzilla

7:37 p.m.

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: statserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

ruben@rubenkerkhof.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |

Red Hat Bugzilla

8 Feb 8 Feb

9:30 p.m.

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: statserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

wolfy@nobugconsulting.ro changed:

Red Hat Bugzilla

9:43 p.m.

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: statserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

wolfy@nobugconsulting.ro changed:

------- Additional Comments From wolfy@nobugconsulting.ro 2007-02-08 16:43 EST ------- - there is no URL tag; please provide one if possible - Package is marked as relocatable; since is a no-no (unless properly documented and justified), PREFIX should disappear - BuildRoot does not have the preferred value - Release tag should include %{dist} - %build does not honor $RPM_OPT_FLAGS - %build should use SMP flags. If it doesn't work, please add a comment - the dot at the end of Summary should be removed - the tar.gz includes the GPL v2 license, but the package claims license to be BSD; - the license file (COPYING) should be included in the binary rpm - I suggest including the provided phone_log script as %doc

Red Hat Bugzilla

9 Feb 9 Feb

11:09 a.m.

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: statserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

twaugh@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review- |fedora-review?

------- Additional Comments From twaugh@redhat.com 2007-02-09 06:09 EST ------- Thanks! Tagged and built as 1.1-39.fc7.

Red Hat Bugzilla

12:21 p.m.

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: statserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

wolfy@nobugconsulting.ro changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|twaugh@redhat.com |wolfy@nobugconsulting.ro

Red Hat Bugzilla

12:23 p.m.

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: statserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

wolfy@nobugconsulting.ro changed:

------- Additional Comments From wolfy@nobugconsulting.ro 2007-02-09 07:23 EST ------- Formal review for release 39:

MUST - package meets naming guidelines - package meets packaging guidelines - license ( GPL ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, sha1sum 3ace36585c82238003b37f267263f06aad4f0afd statserial-1.1.tar.gz - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of foreign files/folders - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - no static, .la, .pc files - rpmlint is silent on src.rpm; for the binary the following warnings are generated: W: statserial spurious-executable-perm /usr/share/doc/statserial-1.1/phone_log W: statserial doc-file-dependency /usr/share/doc/statserial-1.1/phone_log /bin/bash Since phone_log IS a bash script and bash is supposed to be already installed anyway, no additional packages are actually pulled so I guess both warnings can safely be ignored.

SHOULD - Builds fine in mock for FC6 and devel (x86_64) - Runs as advertised on FC6/x86_64

Notes: I have no access to 390 so I can only assume that the hardware being different, the ExcludeArch is justified.

APPROVED

Red Hat Bugzilla

12:45 p.m.

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: statserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

twaugh@redhat.com changed:

------- Additional Comments From twaugh@redhat.com 2007-02-09 07:44 EST ------- Thanks!

Red Hat Bugzilla

13 Feb 13 Feb

noon

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226436

Dmitry Butskoy dmitry@butskoy.name changed:

--- Comment #5 from Dmitry Butskoy dmitry@butskoy.name 2012-02-13 07:00:29 EST --- Package Change Request ====================== Package Name: statserial New Branches: el6 Owners: buc

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

Red Hat Bugzilla

2:48 p.m.

New subject: [Bug 226436] Merge Review: statserial

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226436

--- Comment #6 from Jon Ciesla limburgher@gmail.com 2012-02-13 09:48:49 EST --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

4592

Age (days ago)

6431

Last active (days ago)

package-review@lists.fedoraproject.org

10 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla