Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libnetdude - a libpcap trace file manipulation library
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Summary: Review Request: libnetdude - a libpcap trace file manipulation library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: christian@whoop.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.icir.org/christian/fedora/libnetdude.spec SRPM URL: http://www.icir.org/christian/fedora/libnetdude-0.11-1.src.rpm Description: libnetdude is the packet manipulating backend of Netdude, the network dump data editing framework. It fills the gap between the low-level libpcap API and the high-level requirements for packet manipulation applications. libnetdude provides data types and an API for the most common requirements when dealing with libpcap trace files: trace files, packets, network protocols, packet iterators, packet filters. libnetdude supports manipulation of arbitrarily large trace files, and is extendable through a plugin facility.
Please note: I need a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
manuel wolfshant wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
manuel wolfshant wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |460885
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net
--- Comment #1 from Fabian Affolter fabian@bernewireless.net 2008-09-10 17:05:33 EDT --- rpmlint says... [rpm@laptop024 SRPMS]$ rpmlint libnetdude-0.11-1.src.rpm libnetdude.src:17: W: hardcoded-packager-tag Christian libnetdude.src:19: W: hardcoded-prefix-tag %{prefix} libnetdude.src:47: W: configure-without-libdir-spec libnetdude.src: W: no-version-in-last-changelog 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
Some quick comments on your spec:
- use macros http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros
- Don't use tag 'Packager'
- The Tag 'Release' should incl. %{?dist} and bumped with every new version of your spec file.
- %changelog, add version and release according the sample in the Package HowTo
More details can be found http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |itamar@ispbrasil.com.br Alias| |libnetdude
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limb@jcomserv.net
--- Comment #2 from Jon Ciesla limb@jcomserv.net 2008-09-19 11:22:55 EDT --- Fabian, I can sponsor Christian once you complete the full review. If you like I can just do the review as well. I'll be doing the review this blocks, just want to avoid treading on toes. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
--- Comment #3 from christian@whoop.org 2008-09-19 13:25:52 EDT --- Hi guys, thanks for the sponsor offer and the RPM suggestions. I'll address them asap and post an update when complete.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
--- Comment #4 from Fabian Affolter fabian@bernewireless.net 2008-09-20 16:08:27 EDT --- Jon, I can do a full review later but it would be good if a packager with some experience check my review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
manuel wolfshant wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wolfy@nobugconsulting.ro
--- Comment #5 from manuel wolfshant wolfy@nobugconsulting.ro 2008-09-20 20:55:41 EDT --- Fabian, I suggest to go ahead, assign the bug to yourself and do the review. Either Jon or myself will check after that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2008-09-22 09:15:36 EDT --- (In reply to comment #5)
Fabian, I suggest to go ahead, assign the bug to yourself and do the review. Either Jon or myself will check after that.
+1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2008-10-08 09:29:27 EDT --- I'm willing to do this review. Post updated versions addressing Fabian's comments in #1, and I'll assign to myself and complete.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Michael Schwendt bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@gmx.net Depends on| |460887
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Andreas Thienemann andreas@bawue.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas@bawue.net
--- Comment #8 from Andreas Thienemann andreas@bawue.net 2008-10-17 13:20:49 EDT --- As discussed with christian, I'm offering to do the review as I already did the same work and we'd be able to comaintain the package in the future:
SPEC: http://home.bawue.de/~ixs/libnetdude/libnetdude.spec SRPM: http://home.bawue.de/~ixs/libnetdude/libnetdude-0.11-1.fc9.src.rpm
libnetdude allows to implement trace file manipulations at a much higher level of abstraction than code written directly on top of the pcap library. It also provides a command-line interface that directly lets you script all packet- mangling capabilities provided by the set of plugins you have installed.
[athienem@localhost libnetdude]$ rpmlint /var/lib/mock/fedora-rawhide-*/result/*.rpm 8 packages and 0 specfiles checked; 0 errors, 0 warnings. [athienem@localhost libnetdude]$
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
--- Comment #9 from Jon Ciesla limb@jcomserv.net 2008-10-17 13:39:10 EDT --- Will you be sponsoring him then?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(christian@whoop.o | |rg)
--- Comment #10 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2008-10-24 12:44:44 EDT --- Currently who is the submitter and who is the reviewer?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
--- Comment #11 from Jon Ciesla limb@jcomserv.net 2008-10-24 12:48:28 EDT --- Christian is the submitter, and Andreas is the reviewer, AFAIK. Andreas can now sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Andreas Thienemann andreas@bawue.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(christian@whoop.o | |rg) |
--- Comment #12 from Andreas Thienemann andreas@bawue.net 2008-10-24 12:54:51 EDT --- Jon got that right.
As discussed with Christian, he's happy for me to do the review, so I'll just set the flags then, and assign it.
Everybody happy with that?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Andreas Thienemann andreas@bawue.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
--- Comment #13 from Andreas Thienemann andreas@bawue.net 2008-10-24 12:57:15 EDT --- A note about the libnetdude.spec from me, that one is a package I created for some project at Red Hat and posted here for reference.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Bug 460886 depends on bug 460887, which changed state.
Bug 460887 Summary: Review Request: libpcapnav - a libpcap trace file navigation library https://bugzilla.redhat.com/show_bug.cgi?id=460887
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Resolution| |NOTABUG Status|NEW |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks|177841 |201449 Resolution| |NOTABUG
--- Comment #14 from Jason Tibbitts tibbs@math.uh.edu 2008-11-24 22:19:24 EDT --- Since the submitter hasn't responded to the libpcapnav review after many weeks and multiple pings, it has been closed and thus this must be closed as well.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTABUG |DUPLICATE Flag|fedora-review? |
--- Comment #15 from Jason Tibbitts tibbs@math.uh.edu 2008-12-21 15:35:28 EDT ---
*** This bug has been marked as a duplicate of 477545 ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460886
manuel wolfshant wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|libnetdude |
package-review@lists.fedoraproject.org