https://bugzilla.redhat.com/show_bug.cgi?id=1361672
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zbyszek(a)in.waw.pl
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
The Summary is good, but the %description is a bit lacking: after reading it, I
still don't know *what* this package does... I think you should spell it out in
simple words.
No need to define %sum: just write the first Summary in full, and then you can
refer to that text as %summary.
License tag needs a specific version for GPL. It needs to be one of the "short
names" in
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses.
.egg-info doesn't need to be removed
[
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.o...].
It doesn't work with python3? It would be nicer to package it as a Python3
application if possible.
I think that systemd-devel is probably not required. It is only used to compile
C programs linked with the systemd libs.
python-fmn-sse.noarch: W: incoherent-version-in-changelog 0.1 ['0.1.0-1.fc24',
'0.1.0-1']
python-fmn-sse.noarch: W: summary-ended-with-dot C FMN.SSE allows fedora users
to view their fedmsg feed in realtime.
About the service file: the service most likely shouldn't run as root. Running
a network-facing web server with full privileges is crazy. You should add a
dedicated user (fmn-sse or similar) in %pre.
--
OK, after reading the spec and looking at the files, the biggest issues are:
- can you provide a better overview in %description what the intent of this
package is, this will make further review easier.
- there needs to be some instructions how to enable the service. In particular
I have no idea what the instance argument to the template should be.
- the service should run with reduced privileges.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component