Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-coffee-script - A package for the coffee-script gem
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Summary: Review Request: rubygem-coffee-script - A package for the coffee-script gem Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fotios@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: https://raw.github.com/fotioslindiakos/rubygem-all/master/SPECS/rubygem-coff...
SRPM URL: https://github.com/fotioslindiakos/rubygem-all/raw/master/SRPMS/rubygem-coff...
Description: Ruby CoffeeScript is a bridge to the JS CoffeeScript compiler.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Fotios Lindiakos fotios@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |738744
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Fotios Lindiakos fotios@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |738746
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Fotios Lindiakos fotios@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR), | |738465 Summary|Review Request: |Review Request: |rubygem-coffee-script - A |rubygem-coffee-script - A |package for the |package for the |coffee-script gem |coffee-script Ruby gem
https://bugzilla.redhat.com/show_bug.cgi?id=738742
--- Comment #1 from Jason Tibbitts tibbs@math.uh.edu --- I don't know very much about ruby, but this package doesn't appear to follow the current guidelines very closely at all. https://fedoraproject.org/wiki/Packaging:Ruby
Not knowing ruby I can't comment on how important those differences actually are. Perhaps you could comment on those differences.
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |AwaitingSubmitter
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|738744 |
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |738744
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Bug 738742 depends on bug 738746, which changed state.
Bug 738746 Summary: Review Request: rubygem-coffee-script-source - The CoffeeScript Compiler https://bugzilla.redhat.com/show_bug.cgi?id=738746
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Bug 738742 depends on bug 738744, which changed state.
Bug 738744 Summary: Review Request: rubygem-execjs - ExecJS lets you run JavaScript code from Ruby https://bugzilla.redhat.com/show_bug.cgi?id=738744
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bkabrda@redhat.com Summary|Review Request: |Review Request: |rubygem-coffee-script - A |rubygem-coffee-script - |package for the |Ruby CoffeeScript Compiler |coffee-script Ruby gem |
--- Comment #2 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- Since Fotios has been inactive for quite some time, I'll take this review over.
https://bugzilla.redhat.com/show_bug.cgi?id=738742
--- Comment #3 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- So here are the updated spec and srpm, I created them completely from scratch:
SPEC: http://bkabrda.fedorapeople.org/pkgs/coffee-script/rubygem-coffee-script.spe... SRPM: http://bkabrda.fedorapeople.org/pkgs/coffee-script/rubygem-coffee-script-2.2... Description: Ruby CoffeeScript is a bridge to the JS CoffeeScript compiler. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4246436
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch@redhat.com Assignee|nobody@fedoraproject.org |vondruch@redhat.com Flags| |fedora-review+
--- Comment #4 from Vít Ondruch vondruch@redhat.com --- * The test should be expanded in %check section - I would prefer if the test suite is expanded in the %check section, since in that case, you will avoid the RPM polution. Although admittedly, the %patch macro does not work there, but you can use something like:
cat %{PATCH0} | patch -p1
Since this is just minor nit and the package looks reasonable otherwise, I APPROVE the package.
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- Thanks, I will fix this before importing.
New Package SCM Request ======================= Package Name: rubygem-coffee-script Short Description: Ruby CoffeeScript Compiler Owners: bkabrda Branches: InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=738742
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2012-07-18 01:44:01
https://bugzilla.redhat.com/show_bug.cgi?id=738742
Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
package-review@lists.fedoraproject.org