https://bugzilla.redhat.com/show_bug.cgi?id=1196920
--- Comment #1 from Michael Schwendt (Fedora Packager Sponsors Group)
<bugs.michael(a)gmx.net> ---
Name: log4shib
Group: Development/Libraries
Runtime library base packages have been in group "System Environment/Libraries"
for many years. The group "Development/Libraries" is for the separate
build-time -devel packages.
Nowadays, the Group tag is optional, however:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
Reusing a Fedora spec file for EL is not always a good idea, since differences
in updates and rebuilds introduce a lot of irrelevant crap in the %changelog.
BuildRequires: gcc-c++
JFYI, it is not necessary yet to add this.
https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
%package doc
Summary: Development documentation for %{name}
Group: Development/Libraries
If at all, it would be group "Documentation".
Requires: %{name}%{?_isa} = %{version}-%{release}
Although the guidelines don't cover it [yet], documentation packages ought to
stay free of such unnecessary dependencies. It should be possible to install
documentation packages without pulling in unneeded runtime libs and other
dependencies. That is especially true, if the documentation does not need the
base package to be displayed/viewed by the user.
# Packages are not supposed to add %optflags or %__global_ldflags to
*.pcs
sed -i -e "s|%{optflags}||;s|%{__global_ldflags}||" %{name}.pc
This will require a second look as I've only skimmed over the spec file. It
would be good if the .pc did not add any other unnecessary stuff to
CFLAGS/LDFLAGS.
%files
%defattr(-, root, root, 0755)
Superfluous. %defattr is not necessary anymore for a long time, and a change
from the default (-,root,root,-) would need to be explained:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
%doc ChangeLog
There are a couple of other plain text doc files. Why not include them?
%{_bindir}/log4shib-config
This will need to be checked for multilib conflicts as well as for inserted
CFLAGS/LDFLAGS just like the .pc file. In case there is a conflict, a common
work-around is to have the script query pkg-config instead of redefining
paths/values itself.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component