https://bugzilla.redhat.com/show_bug.cgi?id=1634407
--- Comment #6 from Antonio Trande <anto.trande(a)gmail.com> ---
- Dependencies (save some exception) are automatically resolved.
The 'Requires:' lines are not needed.
- With "BuildRequires: pkgconfig(libssh) <= 0.7.5" you can't currently
build
this package on Fedora because we have 'libssh-0.8.3' available now.
Why this choice?
- Usually, '%post' and '%postun' scriptlets are positioned after
'%install'
section; however, the 'update-desktop-database' commands are not needed anymore
and can be removed.
- Make command?
%build
%configure --with-gtk2
??%make_build??
- All commands you have listed under '%install' (the '$RPM_BUILD_ROOT'
removing
is redundant) are done with a simple
%make_install
- '%defattr' is redundant.
(See
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions)
- Use the macro:
'%{_prefix}/share' --> '%{_datadir}'
- '%{name}.desktop' file is not verified. See
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_...
Postscriptum:
What '%make_build' and '%make_install' commands do? Discover it with the
'--eval' option of 'rpm':
$ rpm --eval %make_build
/usr/bin/make -O -j2
$ rpm --eval %make_install
/usr/bin/make install
DESTDIR=/home/sagitter/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64
INSTALL="/usr/bin/install -p"
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component