https://bugzilla.redhat.com/show_bug.cgi?id=1967876
Bug ID: 1967876 Summary: Review Request: perl-Statistics-ChiSquare - How well-distributed is your data? Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: paul@city-fan.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Statistics-ChiSquare/bran... SRPM URL: http://www.city-fan.org/~paul/extras/perl-Statistics-ChiSquare/perl-Statisti...
Description: Suppose you flip a coin 100 times, and it turns up heads 70 times. Is the coin fair? Suppose you roll a die 100 times, and it shows 30 sixes. Is the die loaded?
In statistics, the chi-square test calculates how well a series of numbers fits a distribution. In this module, we only test for whether results fit an even distribution. It doesn't simply say "yes" or "no". Instead, it gives you a confidence interval, which sets upper and lower bounds on the likelihood that the variation in your data is due to chance.
Fedora Account System Username: pghmcfc
This is a new test dependency of perl-Crypt-Random.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1970378
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1970378 [Bug 1970378] Upgrade perl-Crypt-Random to 1.54
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar ppisar@redhat.com --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: 6523c0e44b53835796c5b3f41cb6281413b79c596601a1971b8cb6fc7b2c76fc53ca60642bc96897083d6504ffc0e5ed35b475df4e9264231a5d602d90b3dd35) is original. Ok. Summary verified from lib/Statistics/ChiSquare.pm. Ok. Description verified from lib/Statistics/ChiSquare.pm. Ok.
License verified from lib/Statistics/ChiSquare.pm. FIXME: Add "and CC-BY-SA" to the License tag (lib/Statistics/ChiSquare.pm:447).
TODO: "make %{?_smp_mflags}" and "make pure_install" invocation can be replacved with "%{make_build}" and "%{make_install}" if "perl Makefile.PL" is augmented.
No XS code, noarch Build is Ok. Build-type dependencies are Ok. All tests pass. Ok.
$ rpmlint perl-Statistics-ChiSquare.spec ../SRPMS/perl-Statistics-ChiSquare-1.0000-1.fc35.src.rpm ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm ========================================================== rpmlint session starts ========================================================= rpmlint: 2.0.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3
=========================== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s ========================== rpmlint is Ok.
rpm -q -lv -p ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm drwxr-xr-x 2 root root 0 Jun 11 12:31 /usr/share/doc/perl-Statistics-ChiSquare -rw-r--r-- 1 root root 514 Oct 21 2016 /usr/share/doc/perl-Statistics-ChiSquare/CHANGELOG -rw-r--r-- 1 root root 265 Jul 23 2011 /usr/share/doc/perl-Statistics-ChiSquare/README drwxr-xr-x 2 root root 0 Jun 11 12:31 /usr/share/licenses/perl-Statistics-ChiSquare -rw-r--r-- 1 root root 6111 Sep 19 2013 /usr/share/licenses/perl-Statistics-ChiSquare/ARTISTIC.txt -rw-r--r-- 1 root root 17987 Sep 19 2013 /usr/share/licenses/perl-Statistics-ChiSquare/GPL2.txt -rw-r--r-- 1 root root 3344 Jun 11 12:31 /usr/share/man/man3/Statistics::ChiSquare.3pm.gz drwxr-xr-x 2 root root 0 Jun 11 12:31 /usr/share/perl5/vendor_perl/Statistics -rw-r--r-- 1 root root 42967 Oct 21 2016 /usr/share/perl5/vendor_perl/Statistics/ChiSquare.pm The file permissions and layout are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Exporter) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm | sort -f | uniq -c 1 perl(Statistics::ChiSquare) = 1.0000 1 perl-Statistics-ChiSquare = 1.0000-1.fc35 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm Binary dependencies are resolvable. Ok.
The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=69848542). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX item and consider fixing the TODO item before building this package. Resolution: Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Statistics-ChiSquare
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #3 from Paul Howarth paul@city-fan.org --- Thanks Petr.
Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/34568
Branches requested: https://pagure.io/releng/fedora-scm-requests/issue/34581 https://pagure.io/releng/fedora-scm-requests/issue/34582 https://pagure.io/releng/fedora-scm-requests/issue/34583 https://pagure.io/releng/fedora-scm-requests/issue/34584
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2021-ba941f42b4 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-ba941f42b4
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-65eae36643 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-65eae36643
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-5a3982ec98 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-5a3982ec98 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5a3982ec98
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2021-9309f7293e has been pushed to the Fedora EPEL 7 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-9309f7293e
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2021-ba941f42b4 has been pushed to the Fedora EPEL 8 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-ba941f42b4
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-65eae36643 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-65eae36643 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-65eae36643
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-5a3982ec98 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-65eae36643 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2021-ba941f42b4 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2021-9309f7293e has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1967876
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Fixed In Version| |perl-Statistics-ChiSquare-1 | |.0000-2.el7 Last Closed| |2022-09-16 15:42:30
package-review@lists.fedoraproject.org