https://bugzilla.redhat.com/show_bug.cgi?id=1466747
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-256:
c9cc863f8c88b251a8cf80c7f30ec77b71a350a64179e72fc02bbbac12c952d9) is original.
Ok
Summary verified from lib/Test/HexDifferences.pm. Ok.
FIX: The description is poor. I recommend something like "This is a Perl module
for testing equivalence of binary data."
License verified from lib/Test/HexDifferences/HexDump.pm and
lib/Test/HexDifferences.pm and README. Ok.
No XS code, noarch BuildArch is Ok.
Test::Prereq::Build not used. Ok.
Test::Perl::Critic not helpful. Ok.
All test pass. Ok.
$ rpmlint perl-Test-HexDifferences.spec
../SRPMS/perl-Test-HexDifferences-1.000-1.fc27.src.rpm
../RPMS/noarch/perl-Test-HexDifferences-1.000-1.fc27.noarch.rpm
perl-Test-HexDifferences.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-Test-HexDifferences/Changes
perl-Test-HexDifferences.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-Test-HexDifferences/README
perl-Test-HexDifferences.noarch: E: wrong-script-interpreter
/usr/share/doc/perl-Test-HexDifferences/example/01_eq_or_dump_diff.t perl -T
perl-Test-HexDifferences.noarch: E: wrong-script-end-of-line-encoding
/usr/share/doc/perl-Test-HexDifferences/example/01_eq_or_dump_diff.t
perl-Test-HexDifferences.noarch: E: wrong-script-interpreter
/usr/share/doc/perl-Test-HexDifferences/example/02_dumped_eq_dump_or_diff.t
perl -T
perl-Test-HexDifferences.noarch: E: wrong-script-end-of-line-encoding
/usr/share/doc/perl-Test-HexDifferences/example/02_dumped_eq_dump_or_diff.t
2 packages and 1 specfiles checked; 4 errors, 2 warnings.
FIX: Normalize end-of-lines in README and Changes.
$ rpm -q -lv -p ../RPMS/noarch/perl-Test-HexDifferences-1.000-1.fc27.noarch.rpm
drwxr-xr-x 2 root root 0 Jun 30 14:42
/usr/share/doc/perl-Test-HexDifferences
-rw-r--r-- 1 root root 1164 Jul 5 2015
/usr/share/doc/perl-Test-HexDifferences/Changes
-rw-r--r-- 1 root root 635 Jul 5 2015
/usr/share/doc/perl-Test-HexDifferences/README
drwxr-xr-x 2 root root 0 Jul 5 2015
/usr/share/doc/perl-Test-HexDifferences/example
-rw-r--r-- 1 root root 2317 Jul 5 2015
/usr/share/doc/perl-Test-HexDifferences/example/01_eq_or_dump_diff.t
-rw-r--r-- 1 root root 2643 Jul 5 2015
/usr/share/doc/perl-Test-HexDifferences/example/02_dumped_eq_dump_or_diff.t
-rw-r--r-- 1 root root 2065 Jun 30 14:42
/usr/share/man/man3/Test::HexDifferences.3pm.gz
-rw-r--r-- 1 root root 2599 Jun 30 14:42
/usr/share/man/man3/Test::HexDifferences::HexDump.3pm.gz
drwxr-xr-x 2 root root 0 Jun 30 14:42
/usr/share/perl5/vendor_perl/Test
drwxr-xr-x 2 root root 0 Jun 30 14:42
/usr/share/perl5/vendor_perl/Test/HexDifferences
-rw-r--r-- 1 root root 5690 Jul 5 2015
/usr/share/perl5/vendor_perl/Test/HexDifferences.pm
-rw-r--r-- 1 root root 10990 Mar 22 2014
/usr/share/perl5/vendor_perl/Test/HexDifferences/HexDump.pm
File layout and permissions are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Test-HexDifferences-1.000-1.fc27.noarch.rpm | sort -f |
uniq -c
1 perl(:MODULE_COMPAT_5.26.0)
1 perl(Hash::Util)
1 perl(strict)
1 perl(Sub::Exporter)
1 perl(Test::Builder::Module) >= 0.99
1 perl(Test::HexDifferences::HexDump)
1 perl(Text::Diff)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p
../RPMS/noarch/perl-Test-HexDifferences-1.000-1.fc27.noarch.rpm | sort -f |
uniq -c
1 perl(Test::HexDifferences) = 1.000
1 perl(Test::HexDifferences::HexDump) = 0.008
1 perl-Test-HexDifferences = 1.000-1.fc27
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-Test-HexDifferences-1.000-1.fc27.noarch.rpm
Binary dependencies resolvable. Ok.
The package builds in F27
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=20263551). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the `FIX' items before building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component