Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: andreas@bawue.net QAContact: fedora-package-review@redhat.com
Spec URL: http://helena.bawue.de/~ixs/perl-NetAddr-IP/perl-NetAddr-IP.spec SRPM URL: http://helena.bawue.de/~ixs/perl-NetAddr-IP/perl-NetAddr-IP-4.004-1.src.rpm Description: This module provides an object-oriented abstraction on top of IP addresses or IP subnets, that allows for easy manipulations. Version 4.xx of NetAdder::IP will will work older versions of Perl and does not use Math::BigInt as in previous versions.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cweyl@alumni.drew.edu Alias| |perl-NetAddr-IP
------- Additional Comments From cweyl@alumni.drew.edu 2007-04-12 15:39 EST ------- Missing br's on:
Test::More Test::Pod Pod::Coverage
There's an rfc included under docs/... Why not add it to %doc?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
------- Additional Comments From andreas@bawue.net 2007-04-26 04:12 EST ------- Kay, new package at http://helena.bawue.de/~ixs/perl-NetAddr-IP/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |cweyl@alumni.drew.edu Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
------- Additional Comments From cweyl@alumni.drew.edu 2007-04-26 11:41 EST ------- Oddly enough, the module itself is (as near as I can determine) definitely under the Artistic license, though it includes a copy of the GPL at Lite/Util/GPL. Weird. --along the same lines, Makefile.PL complains if Test::Pod isn't installed, but no test actually uses it.
The non-versioned requires on perl(NetAddr::IP::Util) would normally need to be filtered, but as this package also provides perl(NetAddr::IP::Util), it's really not worth the effort :)
Missing BR on Test::More -- approval is contingent on this being added (which can be done post-import).
+ source files match upstream: 4f0ef938abf0b1e43ca96fb0068381df NetAddr-IP-4.004.tar.gz 4f0ef938abf0b1e43ca96fb0068381df ../NetAddr-IP-4.004.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. (Artistic) License text not included upstream. + latest version is being packaged. X BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly + debuginfo package looks complete. + rpmlint is silent. + final provides and requires are sane: ** perl-NetAddr-IP-4.004-0.2.fc6.x86_64.rpm == rpmlint == provides Util.so()(64bit) perl(NetAddr::IP) = 4.4 perl(NetAddr::IP::Lite) = 1.5 perl(NetAddr::IP::Util) = 1.3 perl(NetAddr::IP::UtilPP) = 1.2 perl(NetAddr::IP::Util_IS) = 1.00 perl-NetAddr-IP = 4.004-0.2.fc6 == requires libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libnsl.so.1()(64bit) perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(DynaLoader) perl(Exporter) perl(NetAddr::IP::Lite) >= 1.02 O perl(NetAddr::IP::Util) O perl(NetAddr::IP::Util) >= 0.17 perl(NetAddr::IP::Util_IS) perl(strict) perl(vars) ** perl-NetAddr-IP-debuginfo-4.004-0.2.fc6.x86_64.rpm == rpmlint == provides Util.so.debug()(64bit) perl-NetAddr-IP-debuginfo = 4.004-0.2.fc6 == requires + %check is present and all tests pass + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
------- Additional Comments From cweyl@alumni.drew.edu 2007-05-11 11:34 EST ------- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
andreas@bawue.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From andreas@bawue.net 2007-05-16 05:25 EST ------- Sorry, must have missed this being approved.
New Package CVS Request ======================= Package Name: perl-NetAddr-IP Short Description: Manages IPv4 and IPv6 addresses and subnets Owners: andreas@bawue.net Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
steve@silug.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |steve@silug.org
------- Additional Comments From steve@silug.org 2007-07-10 11:08 EST ------- *** Bug 247625 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
------- Additional Comments From tibbs@math.uh.edu 2007-07-10 11:29 EST ------- Is there some reason why this hasn't been built yet?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
andreas@bawue.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From andreas@bawue.net 2007-07-10 11:43 EST ------- fixed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
andreas@bawue.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From andreas@bawue.net 2007-07-10 12:10 EST ------- Package Change Request ====================== Package Name: perl-NetAddr-IP New Branches: F-7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets Alias: perl-NetAddr-IP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-07-10 19:05 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=236177
Red Hat Bugzilla bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |676263
package-review@lists.fedoraproject.org