https://bugzilla.redhat.com/show_bug.cgi?id=970972
Bug ID: 970972 Summary: Review Request: cuisine - Chef-like functionnality for Fabric Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nobody@fedoraproject.org Reporter: nils.fedora@anotherhomepage.org QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://medias.anotherhomepage.org/rpms/cuisine.spec SRPM URL: http://medias.anotherhomepage.org/rpms/cuisine-0.6.4-1.fc18.src.rpm Description: Cuisine is a small set of functions that sit on top of Fabric, to abstract common administration operations such as file/dir operations, user/group creation, package install/upgrade, making it easier to write portable administration and deployment scripts.
Fedora Account System Username: ahpnils
Hi, I just finished packaging up cuisine, and I would appreciate a review so it can be added to Fedora. It might be good to know that I am not an official Fedora Packager, I just created my accounts.
https://bugzilla.redhat.com/show_bug.cgi?id=970972
Nils Ratusznik nils.fedora@anotherhomepage.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
https://bugzilla.redhat.com/show_bug.cgi?id=970972
--- Comment #1 from Nils Ratusznik nils.fedora@anotherhomepage.org --- I forgot to add that this is my first package, and I am seeking a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=970972
François Cami fdc@fcami.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |fdc@fcami.net
--- Comment #2 from François Cami fdc@fcami.net ---
I'll review this.
https://bugzilla.redhat.com/show_bug.cgi?id=970972
François Cami fdc@fcami.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=970972
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@redhat.com Flags| |needinfo?
--- Comment #3 from Miroslav Suchý msuchy@redhat.com --- François can you finish you review, or reassing it back to nobody so somebody else can pick it up? Nils, are you still interrested in this package?
https://bugzilla.redhat.com/show_bug.cgi?id=970972
--- Comment #4 from Nils Ratusznik nils.fedora@anotherhomepage.org --- Hi,
I'm still interrested. I noticed version 0.7.10 is out, here are the updated files :
Spec URL : http://medias.anotherhomepage.org/rpms/cuisine/0.7.10/cuisine.spec SRPM URL : http://medias.anotherhomepage.org/rpms/cuisine/0.7.10/cuisine-0.7.10-1.fc21....
https://bugzilla.redhat.com/show_bug.cgi?id=970972
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|fdc@fcami.net |nobody@fedoraproject.org Flags|needinfo? |
https://bugzilla.redhat.com/show_bug.cgi?id=970972
Athmane Madjoudj athmanem@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |athmanem@gmail.com Assignee|nobody@fedoraproject.org |athmanem@gmail.com Flags| |fedora-review?
--- Comment #5 from Athmane Madjoudj athmanem@gmail.com --- Before doing full review, please consider the following points (You still need a sponsor, sadly I'm not):
1) You dont need "%{__rm} -fr %{buildroot}%{python_sitelib}/paramiko" , since the tarball does not bundle paramiko
2) You need to switch to python2 macros since Fabric is python2-only (Fabric2 will support py3 but that it built on top of Invoke/Paramiko)
3) You should run the test suite in %check section
4) if you are not planning to support EL5, you could remove "%defattr(-,root,root,-)"
5) You must include a license file (using %license macro), already included in the tarball => LICENSE
6) Not a blocker: after quick look into the source code, i did not see any dnf support in package_* operations, which could make this package unusable in Fedora if yum script (dnf wrapper) is removed from base distro.
https://bugzilla.redhat.com/show_bug.cgi?id=970972
--- Comment #6 from Nils Ratusznik nils.fedora@anotherhomepage.org --- I'm facing some difficulties for 3 and 5 : the only available tarbal is from pypi, and it does not include the LICENSE file nor the tests directory.
Otherwise, I should be able to address the other points, and open an issue on upstream's Github for 6.
https://bugzilla.redhat.com/show_bug.cgi?id=970972
--- Comment #7 from Igor Gnatenko ignatenko@redhat.com --- (In reply to Nils Ratusznik from comment #6)
I'm facing some difficulties for 3 and 5 : the only available tarbal is from pypi, and it does not include the LICENSE file nor the tests directory.
just take archive from github.
package-review@lists.fedoraproject.org