Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756435
Tom "spot" Callaway <tcallawa(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |tcallawa(a)redhat.com
AssignedTo|nobody(a)fedoraproject.org |tcallawa(a)redhat.com
Flag| |fedora-review+
--- Comment #5 from Tom "spot" Callaway <tcallawa(a)redhat.com> 2012-04-16
10:56:45 EDT ---
= Review =
Good:
- rpmlint checks return:
pytorctl.src: W: invalid-url Source0: pytorctl-0-20111213git.tar.gz
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Safe to ignore, process for generating source documented in spec file.
- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (cannot do tarball match, but git sync checks out)
- package compiles on f17 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED, pending resolution of 738556 for sponsorship.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.