https://bugzilla.redhat.com/show_bug.cgi?id=1511632
Bug ID: 1511632 Summary: Review Request: nim - statically typed, imperative programming language Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sergey.avseyev@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://avsej.fedorapeople.org/nim/0/nim.spec SRPM URL: https://avsej.fedorapeople.org/nim/0/nim-0.17.2-1.fc28.src.rpm Description: Nim (formerly known as "Nimrod") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).
Fedora Account System Username: avsej Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23020327
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Simplify %files:
%files %license copying.txt dist/nimble/license.txt %doc %{_docdir}/nim/ %{_bindir}/nim* %config(noreplace) %{_sysconfdir}/*.cfg %{_datadir}/nim/ %{_datadir}/nimble/ %{_mandir}/man1/nim*.1* %{bashcompdir}/nim*
%attr(0755, root, root) is not needed as it is the default.
- You might want to consider creating your own RPM macros for this new languaqe in /usr/lib/rpm/macros.d/ , like %nim_arches for defining ExclusiveArches of nim and others to ease the packaging of nim apps.
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
--- Comment #2 from Sergey Avseyev sergey.avseyev@gmail.com --- Thank you for your notes. I've fixed file list, and added macro, although nim.spec itself still using ExcludeArch. I believe later, macro file will be transferred to redhat-rpm-config, or I will extract it to separate package, or just port nim to s390x :)
Spec URL: https://avsej.fedorapeople.org/nim/1/nim.spec SRPM URL: https://avsej.fedorapeople.org/nim/1/nim-0.17.2-1.fc28.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23051441
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- I don't see any changes in %files.
I didn't mean you should add the macros to this package, you could create a separate package, like nim-packaging, for the macros. I don't know how nim package are built, but you could provide other macros in the future for %build, %install, %check and so on if they are standardized.
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
--- Comment #4 from Sergey Avseyev sergey.avseyev@gmail.com --- I see. I haven't packaged any library which using nim-specific package distribution (nimble), but I was going to do it. It makes sense to do before compiler itself will be approved.
Regarding %files, I've removed %attr. What do you mean, when you say "simplify"?
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- See what I posted above: remove the %dir and remove the asterisk after the directories:
%files %license copying.txt dist/nimble/license.txt %doc %{_docdir}/nim/ %{_bindir}/nim* %config(noreplace) %{_sysconfdir}/*.cfg %{_datadir}/nim/ %{_datadir}/nimble/ %{_mandir}/man1/nim*.1* %{bashcompdir}/nim*
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
Sergey Avseyev sergey.avseyev@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1512228
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1512228 [Bug 1512228] Review Request: nim-srpm-macros - RPM macros for building Nimble source packages
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
--- Comment #6 from Sergey Avseyev sergey.avseyev@gmail.com --- I have created separate another package in https://bugzilla.redhat.com/show_bug.cgi?id=1512228, and now I will try to buildroot-override to rebuild this package
https://bugzilla.redhat.com/show_bug.cgi?id=1511632 Bug 1511632 depends on bug 1512228, which changed state.
Bug 1512228 Summary: Review Request: nim-srpm-macros - RPM macros for building Nimble source packages https://bugzilla.redhat.com/show_bug.cgi?id=1512228
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1511632 Bug 1511632 depends on bug 1512228, which changed state.
Bug 1512228 Summary: Review Request: nim-srpm-macros - RPM macros for building Nimble source packages https://bugzilla.redhat.com/show_bug.cgi?id=1512228
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |---
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
--- Comment #7 from Sergey Avseyev sergey.avseyev@gmail.com --- I have updated file list and added more fixes and enhancements, like forcing Fedora hardened compiler flags, building HTML docs, extracting optional tools into separate package etc.
Spec URL: https://avsej.fedorapeople.org/nim/2/nim.spec SRPM URL: https://avsej.fedorapeople.org/nim/2/nim-0.17.2-1.fc28.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23151579
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #8 from Robert-André Mauchin zebob.m@gmail.com --- All good, package accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
--- Comment #9 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nim. You may commit to the branch "f27" in about 10 minutes.
https://bugzilla.redhat.com/show_bug.cgi?id=1511632 Bug 1511632 depends on bug 1512228, which changed state.
Bug 1512228 Summary: Review Request: nim-srpm-macros - RPM macros for building Nimble source packages https://bugzilla.redhat.com/show_bug.cgi?id=1512228
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- nim-0.17.2-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdd61480bc
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nim-0.17.2-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdd61480bc
https://bugzilla.redhat.com/show_bug.cgi?id=1511632
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-12-12 06:19:26
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- nim-0.17.2-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org