Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE. Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mastahnke@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://www.stahnkage.com/rpms/kflickr.spec SRPM URL: http://www.stahnkage.com/rpms/kflickr-0.8-1.src.rpm Description: kflickr is an easy to use photo uploader for flickr written for KDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
------- Additional Comments From panemade@gmail.com 2007-04-26 23:25 EST ------- mock build gave me cp: warning: source file `AUTHORS' specified more than once =>remove double entry of AUTHORS from SPEC and rpmlint on rpm W: kflickr dangling-relative-symlink /usr/share/doc/HTML/en/kflickr/common ../../en/common
=> which I assume for kde packages is OK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From panemade@gmail.com 2007-05-13 09:10 EST ------- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From mastahnke@gmail.com 2007-05-13 22:28 EST ------- I guess I was thinking there would be a more formal review than that. Sorry if that was the review in total. The KDE packages can be this way from what I have read in packaging guidelines.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From panemade@gmail.com 2007-05-13 22:38 EST ------- and I was thought you will update SPEC as suggested in comment #1 :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From panemade@gmail.com 2007-05-13 22:39 EST ------- and remove INSTALL file also from %doc. update new SPEC and submit new links here for SPEC and SRPM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From mastahnke@gmail.com 2007-05-14 19:21 EST ------- http://www.stahnkage.com/rpms/kflickr-0.8-2.src.rpm
http://www.stahnkage.com/rpms/kflickr.spec
I think having the INSTALL file as part of the %doc is normal.
(on rawhide) $ find /usr/share/doc -name INSTALL |wc -l 69
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From panemade@gmail.com 2007-05-14 21:08 EST ------- (In reply to comment #6)
http://www.stahnkage.com/rpms/kflickr-0.8-2.src.rpm
http://www.stahnkage.com/rpms/kflickr.spec
I think having the INSTALL file as part of the %doc is normal.
(on rawhide) $ find /usr/share/doc -name INSTALL |wc -l 69
Yes. I agree still many packages are using INSTALL and I bet most of them must be Core packages which never gone under review. If you see most of extras package should not be having INSTALL. Basically INSTALL file is used by those who want to install tarball manually and not from any rpm format binary. If we are providing rpms then our SPEC file contains all information how/where to install on system. Thats why 69 count is unnecessary files on system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From mastahnke@gmail.com 2007-05-15 00:44 EST ------- Ok, removed INSTALL file. http://www.stahnkage.com/rpms/kflickr-0.8-3.src.rpm
http://www.stahnkage.com/rpms/kflickr.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From panemade@gmail.com 2007-05-15 00:45 EST ------- Baiscally INSTALL COPYING AUTHORS NEWS are files which are having generic contents as they got created with auto* commands.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2007-05-15 01:24 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM - rpmlint is NOT silent RPM. + source files match upstream. cdda0c42b8e492a1c762014187dbfe63 kflickr-0.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text COPYING is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + scriptlets are used. + Provides: libkflickrpart.so + Requires: kdebase >= 3.4 libDCOP.so.4 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libkdecore.so.4 libkdeui.so.4 libkio.so.4 libkparts.so.2 libm.so.6 libqt-mt.so.3 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH) + GUI app. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
mastahnke@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From mastahnke@gmail.com 2007-05-15 08:15 EST ------- New Package CVS Request ======================= Package Name: kflickr Short Description: an easy to use photo uploader for flickr written for KDE. Owners: mastahnke@gmail.com Branches: FC-6, EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From dennis@ausil.us 2007-05-15 08:30 EST ------- cvs done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
mastahnke@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
mastahnke@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Keywords| |Reopened Resolution|NEXTRELEASE | Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From mastahnke@gmail.com 2007-06-09 10:35 EST ------- New Package CVS Request ======================= Package Name: kflickr Short Description: an easy to use photo uploader for flickr written for KDE. Owners: mastahnke@gmail.com Branches: F7 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From tibbs@math.uh.edu 2007-06-09 22:30 EST ------- Branched to F-7.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
mastahnke@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From updates@fedoraproject.org 2007-06-11 18:06 EST ------- kflickr-0.8-3.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
------- Additional Comments From updates@fedoraproject.org 2007-06-16 09:24 EST ------- kflickr-0.8-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |ERRATA Fixed In Version| |0.8-3.fc7
package-review@lists.fedoraproject.org