https://bugzilla.redhat.com/show_bug.cgi?id=1228172
Bug ID: 1228172 Summary: Review Request: jedis - A redis Java client Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: puntogil@libero.it QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://gil.fedorapeople.org/jedis.spec SRPM URL: https://gil.fedorapeople.org/jedis-2.7.2-1.fc20.src.rpm Description: Jedis is a blazingly small and sane Redis java client. Fedora Account System Username: gil
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1228169
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1228169 [Bug 1228169] Review Request: apache-commons-pool2 - Apache Commons Object Pooling Library 2.x series
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1228203
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1228203 [Bug 1228203] Review Request: springframework-data-redis - Provides support to increase developer productivity in Java when using Redis
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hdegoede@redhat.com Assignee|nobody@fedoraproject.org |hdegoede@redhat.com
--- Comment #1 from Hans de Goede hdegoede@redhat.com --- I'll take care of reviewing this one.
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #2 from Hans de Goede hdegoede@redhat.com --- Hi,
I'm afraid that (after building and installing the package from bug 1228169) it does not build for me:
[ERROR] Exit code: 1 - /home/hans/rpmbuild/BUILD/jedis-jedis-2.7.2/src/main/java/redis/clients/jedis
<snip>
[ERROR] /home/hans/rpmbuild/BUILD/jedis-jedis-2.7.2/src/main/java/redis/clients/jedis/BinaryJedis.java:326: error: malformed HTML [ERROR] * @see <ahref="http://code.google.com/p/redis/wiki/ExpireCommand%22%3EExpireCommand</a> [ERROR] ^ [ERROR] /home/hans/rpmbuild/BUILD/jedis-jedis-2.7.2/src/main/java/redis/clients/jedis/BinaryJedis.java:326: error: bad use of '>'
And a few more of these (and also lots of javadoc warnings), I've had build failures of several of my own java packages during the F-23 rebuild, these are caused by javadoc in the F-23/rawhide jdk being stricter.
I've managed to reproduce this issue on F-22 by installing the latest openjdk from F-23 on F-22: http://koji.fedoraproject.org/koji/buildinfo?buildID=651231
This works fine on F-22 and gives you the stricter javadoc, which should allow you to reproduce and then fix this problem.
Also I've a question about the .spec file:
# take too much time and use web connection %mvn_build -f
Can you make the comment better so that it explains things a bit more, also use a web connection? I know maven normally does that, but I thought that %mvn_build disables that ?
Regards,
Hans
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
--- Comment #3 from gil cattaneo puntogil@libero.it --- (In reply to Hans de Goede from comment #2)
Hi,
I'm afraid that (after building and installing the package from bug 1228169) it does not build for me:
[ERROR] Exit code: 1 - /home/hans/rpmbuild/BUILD/jedis-jedis-2.7.2/src/main/java/redis/clients/jedis
<snip>
[ERROR] /home/hans/rpmbuild/BUILD/jedis-jedis-2.7.2/src/main/java/redis/clients/ jedis/BinaryJedis.java:326: error: malformed HTML [ERROR] * @see <ahref="http://code.google.com/p/redis/wiki/ExpireCommand%22%3EExpireCommand</a> [ERROR] ^ [ERROR] /home/hans/rpmbuild/BUILD/jedis-jedis-2.7.2/src/main/java/redis/clients/ jedis/BinaryJedis.java:326: error: bad use of '>'
And a few more of these (and also lots of javadoc warnings), I've had build failures of several of my own java packages during the F-23 rebuild, these are caused by javadoc in the F-23/rawhide jdk being stricter.
for a maven build you should remove maven-javadoc-plugin from POM file/s for a ant build you should add: e.g. version="true" use="true" windowtitle="Classycle" - failonerror="true"/> + failonerror="true"> + <arg value="-Xdoclint:none"/> + </javadoc> or e.g. <javadoc destdir="${javadoc.dir}" source="1.6" failonerror="true" access="protected" + additionalparam="-Xdoclint:none" windowtitle="JGraphT : a free Java graph library" overview="${src.dir}/overview.html"> <classpath refid="build.classpath" />
I've managed to reproduce this issue on F-22 by installing the latest openjdk from F-23 on F-22: http://koji.fedoraproject.org/koji/buildinfo?buildID=651231
FiXED, remove maven-javadoc-plugin to use default javadoc setting to override doclint issues
This works fine on F-22 and gives you the stricter javadoc, which should allow you to reproduce and then fix this problem.
Also I've a question about the .spec file:
# take too much time and use web connection %mvn_build -f
Can you make the comment better so that it explains things a bit more, also use a web connection? I know maven normally does that, but I thought that %mvn_build disables that ?
The test suite require unavailable resources, especially if the builder is a ARM arch based. These builders are pretty slow compared to other arch. Moreover, we don't have JIT enabled on this architecture, so everything runs in interpreted mode. Package builds can be one to three orders of magnitude slower on armv7hl compared to x86_64 and often fail due to timeouts or OutOfMemoryError. For "real" builds the only known workaround is resubmitting the build until you get non-ARM builder. Is a waste of time and resources.
Regards,
Hans
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
--- Comment #4 from gil cattaneo puntogil@libero.it --- Spec URL: https://gil.fedorapeople.org/jedis.spec SRPM URL: https://gil.fedorapeople.org/jedis-2.7.2-2.fc20.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
--- Comment #5 from gil cattaneo puntogil@libero.it --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10242377
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
--- Comment #6 from gil cattaneo puntogil@libero.it --- Spec URL: https://gil.fedorapeople.org/jedis.spec SRPM URL: https://gil.fedorapeople.org/jedis-2.7.2-2.fc22.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Hans de Goede hdegoede@redhat.com --- Hi,
(In reply to gil cattaneo from comment #6)
Spec URL: https://gil.fedorapeople.org/jedis.spec SRPM URL: https://gil.fedorapeople.org/jedis-2.7.2-2.fc22.src.rpm
Thanks, sorry for being a bit slow to respond.
Full review done:
Good: - rpmlint checks return: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
Everything looks good: Approved.
Regards,
Hans
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from gil cattaneo puntogil@libero.it --- Thanks for the review!
New Package SCM Request ======================= Package Name: jedis Short Description: A redis Java client Upstream URL: https://github.com/xetorthio/jedis Owners: gil InitialCC: java-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |jedis-2.7.2-2.fc23 Resolution|--- |RAWHIDE Last Closed| |2015-07-09 22:49:33
--- Comment #10 from gil cattaneo puntogil@libero.it --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10329821
https://bugzilla.redhat.com/show_bug.cgi?id=1228172 Bug 1228172 depends on bug 1228169, which changed state.
Bug 1228169 Summary: Review Request: apache-commons-pool2 - Apache Commons Object Pooling Library 2.x series https://bugzilla.redhat.com/show_bug.cgi?id=1228169
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
--- Comment #11 from gil cattaneo puntogil@libero.it --- Package Change Request ====================== Package Name: jedis New Branches: f22 Owners: gil InitialCC: java-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
--- Comment #12 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- jedis-2.7.2-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14667
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords| |Reopened
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- jedis-2.7.2-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jedis'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14667
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- jedis-2.7.2-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1228172
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version|jedis-2.7.2-2.fc23 |2.7.2-2.fc22 Resolution|--- |NEXTRELEASE Last Closed|2015-07-09 22:49:33 |2015-09-09 19:19:50
package-review@lists.fedoraproject.org