https://bugzilla.redhat.com/show_bug.cgi?id=2183874
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |decathorpe(a)gmail.com
Status|NEW |POST
Flags| |fedora-review+
Assignee|nobody(a)fedoraproject.org |decathorpe(a)gmail.com
--- Comment #1 from Fabio Valentini <decathorpe(a)gmail.com> ---
Package was generated with rust2rpm, simplifying the review.
Review was finished using built dependencies from the linked COPR.
- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (there are no unit tests, and
doctests are enabled)
! latest version of the crate is packaged (v0.2.20 -> v0.2.21)
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines
Package APPROVED.
===
Please just disable tests entirely (i.e. %bcond_without -> %bcond_with).
There are no unit tests, and doctests are disabled, so flipping the bcond would
be easier.
Note that v0.2.21 is now the latest version, but it depends on owned_ttf_parser
-> ttf-parser v0.19, which are not updated yet, so keeping this package at
v0.2.20 until the other two packages can be updated is fine.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2183874