https://bugzilla.redhat.com/show_bug.cgi?id=2294766
Bug ID: 2294766 Summary: Review Request: ocaml-ppxlib-jane - Utilities for working with Jane Street AST constructs Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loganjerry@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jjames.fedorapeople.org/ocaml-ppxlib-jane/ocaml-ppxlib-jane.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-ppxlib-jane/ocaml-ppxlib-jane-0.17.0-1... Fedora Account System Username: jjames Description: A library for use in ppxes for constructing and matching on ASTs corresponding to the augmented parsetree that is recognized by the Jane Street OCaml compiler (flambda).
ASTs constructed using this library are compatible with the standard OCaml compiler. Any syntax change known to this library is encoded as attributes, and the standard OCaml compiler's interpretation of the ASTs constructed by these library (which amounts to ignoring the attributes) is reasonable. That is, we only expose "unsurprising" things in this library. For example, if you construct an *n*-ary function using this library, the standard OCaml compiler will interpret it as *n* nested unary functions in the normal way.
Likewise, ppxes that use this library to match on Jane Street ASTs can also be used with the standard OCaml compiler. (The Jane Street AST cases of the match will just never be triggered when using the standard OCaml compiler.)
This package is needed to update the Jane Street packages from their 0.16.x versions to 0.17.x. The builds have all been done in a COPR: https://copr.fedorainfracloud.org/coprs/jjames/JaneStreet/.
I am willing to swap reviews.
https://bugzilla.redhat.com/show_bug.cgi?id=2294766
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/janestre | |et/ppxlib_jane
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7690171 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org