https://bugzilla.redhat.com/show_bug.cgi?id=1340884
Rex Dieter <rdieter(a)math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |rdieter(a)math.unl.edu
Blocks| |656997 (kde-reviews)
Assignee|nobody(a)fedoraproject.org |rdieter(a)math.unl.edu
Alias| |krita
Flags| |fedora-review?
--- Comment #3 from Rex Dieter <rdieter(a)math.unl.edu> ---
I can review, some initial comments:
1. MUST: drop -devel subpkg, there's no public API (headers), better to omit
%{_libdir}/libkrita*.so
from packaging
2. SHOULD consider a -libs subpkg, for multilib friendliness, to include
shared libraries and plugins, basically:
%{_libdir}/libkrita*.so.*
3. SHOULD support better upgrade path from calligra-krita, add
Obsoletes: calligra-krita < 3.0
Provides: calligra-krita = %{version}-%{release}
# add to -libs pkg, if you choose to create one per item 2
Obsoletes: calligra-krita-libs < 3.0
Provides: calligra-krita-libs = %{version}-%{release}
4. Source URL invalid, MUST use (something like)
Source0:
http://download.kde.org/stable/krita/%{version}/krita-%{version}.tgz
(without this, I cannot verify sources either, since the Source used currently
has a different extension .tar.xz)
5. MUST add missing icon/mimetype/shlib scriptlets:
%post
touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :
%posttrans
gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || :
update-desktop-database -q &> /dev/null ||:
%postun
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :
gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || :
update-desktop-database -q &> /dev/null ||:
fi
and to -libs:
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig
6. SHOULD simplify Summary/Description, mentioning "FREE" is extraneous
(everything in fedora is free already), I'd suggest just
Summary: A sketching and painting program
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component