https://bugzilla.redhat.com/show_bug.cgi?id=1914739
--- Comment #3 from Jiri Kastner <cz172638(a)gmail.com> ---
dependencies:
rt-tests => realtime-tests
probably add stress-ng
########
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package installs properly.
Note: Installation errors (see attachment)
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is not marked as %license
See:
https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
===== MUST items =====
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GNU General Public License, Version 2", "Unknown or
generated", "GNU General Public License v2.0 or later", "GNU
General
Public License, Version 2 [obsolete FSF postal address (Mass Ave)]",
"GNU General Public License v2.0 or later [obsolete FSF postal address
(Temple Place)]", "GNU General Public License", "BSD 2-clause
"Simplified" License". 38 files have unknown license. Detailed output
of licensecheck in /home/indy/packaging/review/review-
rteval/licensecheck.txt
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python3.9/site-packages/rteval,
/usr/lib/python3.9/site-packages/rteval/__pycache__
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.9/site-
packages/rteval/__pycache__, /usr/lib/python3.9/site-packages/rteval
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 3 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build
process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[ ]: Buildroot is not present
Note: Buildroot: present but not needed
[ ]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ]: Scriptlets must be sane, if used.
[ ]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Rpmlint is run on all installed packages.
Note: Mock build failed
See:
https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_use_rpmlint
[x]: Spec file according to URL is the same as in SRPM.
Installation errors
-------------------
INFO: mock.py version 2.9 starting (python version = 3.9.1, NVR =
mock-2.9-1.fc33)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 2.9
INFO: Mock Version: 2.9
Finish: chroot init
INFO: installing package(s):
/home/indy/packaging/review/review-rteval/results/rteval-3.1-2.fc34.noarch.rpm
ERROR: Command failed:
# /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
--releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local
--disableplugin=spacewalk install
/home/indy/packaging/review/review-rteval/results/rteval-3.1-2.fc34.noarch.rpm
--setopt=tsflags=nocontexts
Rpmlint
-------
Checking: rteval-3.1-2.fc34.noarch.rpm
rteval-3.1-2.fc34.src.rpm
rteval.noarch: E: devel-dependency elfutils-libelf-devel
rteval.noarch: W: spelling-error %description -l en_US hackbench -> backbench,
hack bench, hack-bench
rteval.noarch: W: spelling-error %description -l en_US cyclictest -> cyclic
test, cyclic-test, bicyclist
rteval.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/rteval/misc.py 644 /usr/bin/python3 -tt
rteval.noarch: E: incorrect-fsf-address
/usr/lib/python3.9/site-packages/rteval/misc.py
rteval.src: W: spelling-error %description -l en_US hackbench -> backbench,
hack bench, hack-bench
rteval.src: W: spelling-error %description -l en_US cyclictest -> cyclic test,
cyclic-test, bicyclist
rteval.src: W: invalid-url Source0: rteval-3.1.tar.xz
2 packages and 0 specfiles checked; 3 errors, 5 warnings.
Requires
--------
rteval (rpmlib, GLIBC filtered):
/usr/bin/python3
bc
bison
bzip2
config(rteval)
elfutils
elfutils-libelf-devel
flex
gcc
kernel-headers
make
numactl
openssl
openssl-devel
python(abi)
python3-dmidecode
python3-ethtool
python3-lxml
python3-schedutils
rt-tests
rteval-loads
sos
sysstat
tar
xz
Provides
--------
rteval:
config(rteval)
python3.9dist(rteval)
python3dist(rteval)
rteval
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/bin/fedora-review -n rteval
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: Haskell, SugarActivity, Ocaml, Java, R, C/C++, PHP, Perl,
fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component