Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: vtk - The Visualization Toolkit - A high level 3D visualization
library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199405
------- Additional Comments From pertusus(a)free.fr 2006-09-12 11:26 EST -------
(In reply to comment #17)
What is the status of this bug report?
The licence issue is a blocker, and maybe also the inclusion of
other packages within vtk.
Patrice do you want to do a formal review?
I am waiting for the current issues to be solved before I
continue reviewing, but I don't really care whether I am
the formal reviewer or not.
Needs work:
* BuildRoot should
be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
(wiki: PackagingGuidelines#BuildRoot)
The BuildRoot in the spec file is also right now.
* BuildRequires: gcc-c++ should not be included
(wiki: PackagingGuidelines#Exceptions)
It could be included (this is not a blocker), but I
agree that it is better without.
This is relevant in the case of /usr/lib/, is this on purpose?
This shows in rpmlint of the source rpm:
E: vtk hardcoded-library-path in %{_prefix}/lib/*`"
E: vtk hardcoded-library-path in %{_prefix}/lib/*
Seems like there is something unclean in the code...
Minor:
* QT environment variable are not sourced
This may not be so minor, since it may lead to issues
on lib64 architectures with some qt versions.
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.