Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: django-followit - A django app that allows users to follow django model objects
https://bugzilla.redhat.com/show_bug.cgi?id=720149
Summary: Review Request: django-followit - A django app that allows users to follow django model objects Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kumarpraveen.nitdgp@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: ---
Spec URL: http://kumarpraveen.fedorapeople.org/django-followit/django-followit.spec SRPM URL: http://kumarpraveen.fedorapeople.org/django-followit/django-followit-0.0.1-1... Description: The django-followit django app allows to easily set up a capability for the site users to follow various things on the site, represented by django model objects.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
Praveen Kumar kumarpraveen.nitdgp@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
pjp pj.pandit@yahoo.co.in changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pj.pandit@yahoo.co.in AssignedTo|nobody@fedoraproject.org |pj.pandit@yahoo.co.in
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
--- Comment #1 from pjp pj.pandit@yahoo.co.in 2011-07-10 15:22:34 EDT --- [X] Package name - ok. [X] Package group - ok. [X] Package license: BSD - ok. [X] Build successful - ok.
[X] rpmlint SRPMS/django-followit-0.0.1-1.20110709gitb53320.fc14.src.rpm django-followit.src: W: invalid-url Source0: django-followit-0.0.1.20110709gitb53320.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
- ok(source is pulled from git repository).
[X] rpmlint RPMS/noarch/django-followit-0.0.1-1.20110709gitb53320.fc14.noarch.rpm django-followit.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
- %doc section needs documents.
[X] Install/Un-install - ok.
Overall good. Please supply some documentation in %doc LICENSE README ...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
--- Comment #2 from Praveen Kumar kumarpraveen.nitdgp@gmail.com 2011-07-10 22:35:46 EDT --- Source is only contain a zero-size README.txt so should I remove doc section ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
--- Comment #3 from pjp pj.pandit@yahoo.co.in 2011-07-11 01:51:27 EDT --- Removing %doc does not sound like a good idea. May be you could write a README explaining what the package is about and how it is useful. You could also include LICNESE file in %doc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
--- Comment #4 from Praveen Kumar kumarpraveen.nitdgp@gmail.com 2011-07-17 09:25:33 EDT --- Added license file. Updated spec : http://kumarpraveen.fedorapeople.org/django-followit/django-followit.spec Update srpm : http://kumarpraveen.fedorapeople.org/django-followit/django-followit-0.0.1-2...
koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3205158
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
--- Comment #5 from pjp pj.pandit@yahoo.co.in 2011-07-17 10:29:32 EDT --- [X] Package name - ok [X] Pacakge group - ok. [X] Package license - ok. [X] Build successful - ok.
[X] pmlint SRPMS/django-followit-0.0.1-2.20110717git15ced1.fc14.src.rpm django-followit.src: W: invalid-url Source0: django-followit-0.0.1.20110717git15ced1.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
- ok.
[X] rpmlint RPMS/noarch/django-followit-0.0.1-2.20110717git15ced1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
- ok.
[X] Install/Un-install - ok.
[root]# rpm -ivh django-followit-0.0.1-2.20110717git15ced1.fc14.noarch.rpm Preparing... ########################################### [100%] 1:django-followit ########################################### [100%] [root]# rpm -ev django-followit-0.0.1-2.20110717git15ced1.fc14 [root]# rpm -qa | grep django-followit
Overall good.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
pjp pj.pandit@yahoo.co.in changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from pjp pj.pandit@yahoo.co.in 2011-07-17 10:30:07 EDT --- Approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
--- Comment #7 from Praveen Kumar kumarpraveen.nitdgp@gmail.com 2011-07-17 10:38:56 EDT --- New Package SCM Request ======================= Package Name: django-followit Short Description: A django app that allows users to follow django model objects Owners: kumarpraveen Branches: f14 f15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@gmail.com
--- Comment #8 from Rahul Sundaram metherid@gmail.com 2011-07-17 18:15:55 EDT --- django-followit is now in pypi, has a release tarball and the license included in this tarball. You should update your spec for using this url and the tarball there
http://pypi.python.org/pypi/followit/
Also instead of mv, you could use %doc followit/LICENSE or define a macro, %global srcname followit and then using that macro consistently throughout the spec.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
--- Comment #9 from Rahul Sundaram metherid@gmail.com 2011-07-17 18:19:30 EDT --- Also add PKG-INFO to %doc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
Praveen Kumar kumarpraveen.nitdgp@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from Praveen Kumar kumarpraveen.nitdgp@gmail.com 2011-07-17 20:56:48 EDT --- Done SPEC url : http://kumarpraveen.fedorapeople.org/django-followit/django-followit.spec SRPM url : http://kumarpraveen.fedorapeople.org/django-followit/django-followit-0.0.2-3...
koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3205985
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
--- Comment #11 from Rahul Sundaram metherid@gmail.com 2011-07-17 21:32:21 EDT --- New Package SCM Request ======================= Package Name: django-followit Short Description: A django app that allows users to follow django model objects Owners: kumarpraveen sundaram pjp Branches: f14 f15 el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720149
--- Comment #12 from Jon Ciesla limb@jcomserv.net 2011-07-17 22:54:46 EDT --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=720149
pjp pj.pandit@yahoo.co.in changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2014-06-27 16:39:19
package-review@lists.fedoraproject.org