https://bugzilla.redhat.com/show_bug.cgi?id=2293850
Bug ID: 2293850 Summary: Review Request: golang-github-hamba-avro2 - A fast Go Avro codec Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-hamba-avro2.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-hamba-avro2-2.22....
Description: A fast Go Avro codec.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2293849
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Copr build: https://copr.fedorainfracloud.org/coprs/eclipseo/gotests/build/7654972/ (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/eclipseo/gotests/fedora-r...
Please take a look if any issues were found.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2293849 [Bug 2293849] Review Request: golang-github-ettle-strcase - Go package to convert strings to snake_case, camelCase, kebab-case
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7655028 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@olasagasti.info Status|NEW |ASSIGNED
--- Comment #3 from Mikel Olasagasti Uranga mikel@olasagasti.info --- I would like to understand better this package.
- Is it required by other package? I see no `gometa -f` is used, so it may be required by other package, but unclear which one. - If the package is required by others, would it be better to make it a source only package? That way is easier to track if it's a leave package in the future. - Is the package binary only? if so, why not add `gometa -f` and remove `gopkginstall` and `gopkgfiles`
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mikel@olasagasti.info
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
--- Comment #4 from Robert-André Mauchin 🐧 zebob.m@gmail.com ---
Is it required by other package?
Yes, that's why no -f
https://github.com/apache/arrow/blob/main/go/go.mod
We have two binaries described in : https://github.com/hamba/avro?tab=readme-ov-file#go-structs-generation
But yeah this is optonal.
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
--- Comment #5 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-hamba-avro2.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-hamba-avro2-2.22....
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7693831 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
--- Comment #7 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Copr build: https://copr.fedorainfracloud.org/coprs/eclipseo/gotests/build/7693830/ (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/eclipseo/gotests/fedora-r...
Please take a look if any issues were found.
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #8 from Mikel Olasagasti Uranga mikel@olasagasti.info --- This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [x] There are no `%{_bindir}/*` wildcards in %files. - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2293850
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #9 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-hamba-avro2
package-review@lists.fedoraproject.org