Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-HTTP-Parser-XS - A fast, primitive HTTP request parser Alias: perl-HTTP-Parser-XS
https://bugzilla.redhat.com/show_bug.cgi?id=579389
Summary: Review Request: perl-HTTP-Parser-XS - A fast, primitive HTTP request parser Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/HTTP-Parser-XS OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~cweyl/review/perl-HTTP-Parser-XS.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-HTTP-Parser-XS-0.07-1.fc12.src.rp...
Description: HTTP::Parser::XS is a fast, primitive HTTP request parser that can be used either for writing a synchronous HTTP server or an event- driven server.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2094717
Additional Comment:
This package is an optional run-time dependency of plack.
*rt-0.10_01
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579389
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@cern.ch AssignedTo|nobody@fedoraproject.org |steve.traylen@cern.ch Flag| |fedora-review+
--- Comment #1 from Steve Traylen steve.traylen@cern.ch 2010-04-05 16:15:57 EDT --- Review: perl-HTTP-Parser-XS Date: April 5th 2010 Mock Build: F14 x86_64 okay.
* PASS: rpmlint output $ rpmlint RPMS/x86_64/perl-HTTP-Parser-XS-* SPECS/perl-HTTP-Parser-XS.spec SRPMS/perl-HTTP-Parser-XS-0.07-1.fc13.src.rpm perl-HTTP-Parser-XS-tests.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 1 warnings.
* PASS: Named according to the Package Naming Guidelines. yes perl * PASS: spec file name same as base package %{name}. yes perl * PASS: Packaging Guidelines. * PASS: Approved license in .spec file. perl * PASS: License on Source code. The README is clear but META.yml contains license: ~ maybe a note could be passed to upsteam. * PASS: Include LICENSE file or similar if it exist. * PASS: Written in American English. * PASS: Spec file legible. * PASS: Included source must match upstream source. $ md5sum HTTP-Parser-XS-0.07.tar.gz ../SOURCES/HTTP-Parser-XS-0.07.tar.gz 890711d599f036fe613b3c8589000a10 HTTP-Parser-XS-0.07.tar.gz 890711d599f036fe613b3c8589000a10 ../SOURCES/HTTP-Parser-XS-0.07.tar.gz
* PASS: Build on one architecture. mock build * PASS: Not building on an architecture must highlighted. mock build * PASS: Build dependencies must be listed in BuildRequires. mock build * PASS: Handle locales properly. None present * PASS: ldconfig must be called on shared libs. None present. * PASS: No bundled copies of system libraries. None present. * PASS: Package must state why relocatable if relocatable. Not relocatable. * PASS: A package must own all directories that it creates Yes. * PASS: No duplicate files in %files listings. None * PASS: Permissions on files must be set properly. %defattr * PASS: %clean section contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). * PASS: Each package must consistently use macros. * PASS: The package must contain code, or permissable content. * PASS: Large documentation files must go in a -doc subpackage. None present. * PASS: %doc must not affect the runtime of the application. * PASS: Header files must be in a -devel package. none present. * PASS: Static libraries must be in a -static package. none present. * PASS: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' none present. * PASS: devel packages must require the exact base package * PASS: No .la libtool archives * PASS: GUI apps should have %{name}.desktop file None * PASS: No files or directories already owned by other packages. None * PASS: %install must run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). * PASS: All filenames in rpm packages must be valid UTF-8.
Comments: 1) Presumably the "tests" subpackage could be noarch. Only makes sense to fix if it can be done in a generic way of course. 2) The license is clear in the README but the META.yml contains license: ~ maybe a note upstream asking them to fix would be good.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579389
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2010-04-10 14:36:24 EDT --- New Package CVS Request ======================= Package Name: perl-HTTP-Parser-XS Short Description: A fast, primitive HTTP request parser Owners: cweyl Branches: F-11 F-12 F-13 devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579389
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579389
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2010-04-11 15:19:13 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579389
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #4 from Chris Weyl cweyl@alumni.drew.edu 2010-04-12 01:56:40 EDT --- Thanks for the review! :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579389
Emmanuel Seyman emmanuel.seyman@club-internet.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |emmanuel.seyman@club-intern | |et.fr Flag|fedora-cvs+ |fedora-cvs?
--- Comment #5 from Emmanuel Seyman emmanuel.seyman@club-internet.fr 2012-02-09 17:50:30 EST --- New Package SCM Request ======================= Package Name: perl-HTTP-Parser-XS Short Description: A fast, primitive HTTP request parser Owners: eseyman bochecha Branches: el6 InitialCC: perl-sig
I've been asked by Mathieu Bridon (bochacha) to create a el6 branch for this module. Since I'm a helpful guy, I'ld be really glad if someone did this for me. :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579389
--- Comment #6 from Jon Ciesla limburgher@gmail.com 2012-02-09 21:34:59 EST --- Love to, but it needs to be a Package Change request, not New Package.
https://fedoraproject.org/wiki/Package_SCM_admin_requests
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579389
Emmanuel Seyman emmanuel.seyman@club-internet.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Emmanuel Seyman emmanuel.seyman@club-internet.fr 2012-02-10 01:43:39 EST --- I knew I was going to do it wrong.
Package Change Request ====================== Package Name: perl-HTTP-Parser-XS New Branches: el6 Owners: eseyman bochecha InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579389
--- Comment #8 from Jon Ciesla limburgher@gmail.com 2012-02-10 07:53:20 EST --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org