Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: PySolFC - A collection of solitare card games
https://bugzilla.redhat.com/show_bug.cgi?id=312701
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs(a)math.uh.edu 2007-10-22 01:39 EST -------
Too bad when I got home my Internet connection had crapped out. It's not much
better now but I got through long enough to have a longer look at this.
Looks like you need to s/imageing/imaging/ in your spec. You could probably
drop some of the manual dependencies (at least python-imaging and tkinter) if
you wanted, but it's not a big deal.
Unfortunately the bug that was blocking this has been closed but the fix hasn't
been pushed yet, and it hasn't been fixed for F8 either. I expect that the F7
fix will be pushed before this package, but I don't know about F8.
Not a blocker, but perhaps you could consider having this package provide
"pysol" since that's the name of the executable it provides and it would
make it
a bit easier on people looking for a pysol package. I can see a few reasons why
you might not want to do this, though, so I'll leave it up to you.
rpmlint says:
PySolFC.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/pysollib/games/siebenbisas.py 0644
which I don't see as a problem; it's just the usual "anything python starts
with
a shebang even if it's not an executable" disease which python programmers seem
to acquire.
I never ran through my checklist, so:
* source files match upstream:
768dd5be8ec1f0d8f62792e712a177bdae8e01993a12f2c84fe1c9c56f17daee
PySolFC-1.1.tar.bz2
(downloaded manually because sourceforge is sucking as usual)
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint has acceptable complaints.
* final provides and requires are sane:
PySolFC = 1.1-2.fc8
=
/bin/sh
/usr/bin/env
/usr/bin/python
python(abi) = 2.5
python-imaging
python-imaging-tk
tcl
tile
tix
tk
tkinter
* %check is not present; no test suite upstream. Manually tested with fixed
python.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* desktop file present and installed properly.
* locale files handled properly.
APPROVED; just fix the "imageing" bit before you check in.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.