https://bugzilla.redhat.com/show_bug.cgi?id=1400236
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbyszek(a)in.waw.pl
--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
(In reply to Dhanesh B. Sabane from comment #1)
Disclaimer: This is an unofficial review.
* Use the modname macro in the package name too.
Why?
* There is no need to declare a separate macro for summary. Just
enter the
summary for the first time and then you can use %{summary} everywhere else.
* Source0 is incorrect. It should be
%{url}/archive/%{version}.tar.gz
What do you mean by incorrect? Including the part
after # allows the tarball to
be renamed (spectool will use the part after the last slash as the output
name).
* The license associated with the source seems to be ISC only. I
don't
understand why ASL is required here.
* The description is too terse. Could you elaborate a bit?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component